ci: temporarily disable overflow checks again. #90228
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
cc @hkratz |
matthiaskrgr
force-pushed
the
fix_ci_disable_overflow_checks
branch
from
482458b
to
700c61c
Compare
. rust-lang#89776 enabled overflow checks in CI but these lead to two failures already: rust-lang#90042 (comment) rust-lang#90222 (comment) The (first?) problem has been identified: rust-lang#90227 This PR temporarily disables the overflow checks again so we don't have to deal with the "spurious" CI failures until rustc-rayon is fixed. Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/ci.20failed.20with.20.20.22attempt.20to.20subtract.20with.20overflow.22
matthiaskrgr
force-pushed
the
fix_ci_disable_overflow_checks
branch
from
700c61c
to
edae201
Compare
|
Can we limit this just to rustc-rayon (via an override in Cargo.toml) or builders enabling the parallel compiler, without which rustc-rayon shouldn't be used iirc? |
|
I tried to somehow modify cargo flags of the rustc-rayon dependency via rustcs Cargo.toml but without success. :/ |
|
Putting this in the top-level Cargo.toml should work: [profile.release.package.rustc-rayon-core]
overflow-checks = falseWe already do this for compiler-builtins. Edited: Overflow is indeed in rustc-rayon-core. |
|
Don't we need it in rustc-rayon-core? Maybe I'm misremembering but I saw it mentioned somewhere |
|
@hkratz can you open a pr? I'd close this in favor of a cargo.toml fix then :) |
|
Great, thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#89776 enabled overflow checks in CI but these lead to two failures already:
#90042 (comment)
#90222 (comment)
The (first?) problem has been identified: #90227
This PR temporarily disables the overflow checks again so we don't have to deal with the "spurious" CI failures until rustc-rayon is fixed.
Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/ci.20failed.20with.20.20.22attempt.20to.20subtract.20with.20overflow.22