Skip to content

Commit

Permalink
ci: temporarily disable overflow checks again.
Browse files Browse the repository at this point in the history
. #89776 enabled overflow checks in CI but these lead to two failures already:

#90042 (comment)
#90222 (comment)

The (first?) problem has been identified: #90227

This PR temporarily disables the overflow checks again so we don't have to deal with the "spurious" CI failures until rustc-rayon is fixed.

Zulip discussion: https://rust-lang.zulipchat.com/#narrow/stream/131828-t-compiler/topic/ci.20failed.20with.20.20.22attempt.20to.20subtract.20with.20overflow.22
  • Loading branch information
matthiaskrgr committed Oct 24, 2021
1 parent a99c9d6 commit edae201
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion src/ci/run.sh
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,9 @@ else
fi

# Same for overflow checks
if [ "$NO_OVERFLOW_CHECKS" = "" ]; then
# Note: temporarily disabled to prevent CI failures due to overflow in rustc-rayon dependency
# Reenable once https://github.com/rust-lang/rust/issues/90227 is fixed
if [ "$NO_OVERFLOW_CHECKS" = "" ] && false; then
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-overflow-checks"
fi

Expand Down

0 comments on commit edae201

Please sign in to comment.