Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #85838

Merged
merged 18 commits into from
May 30, 2021
Merged

Rollup of 8 pull requests #85838

merged 18 commits into from
May 30, 2021

Commits on May 27, 2021

  1. Do not try to build LLVM with Zlib on Windows

    We do not install Zlib on the CI but recent builds somehow started picking it's shared version.
    To avoid relying on CI binaries so let's explicitly disable it.
    mati865 committed May 27, 2021
    Configuration menu
    Copy the full SHA
    53bf79e View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. Remove --print unversioned-files from rustdoc

    This flag isn't needed anymore. See rust-lang#83784.
    Bobo1239 committed May 28, 2021
    Configuration menu
    Copy the full SHA
    8b6dad2 View commit details
    Browse the repository at this point in the history

Commits on May 29, 2021

  1. Add String::extend_from_within

    This patch adds `String::extend_from_within` function under the
    `string_extend_from_within` feature gate similar to the
    `Vec::extend_from_within` function.
    WaffleLapkin committed May 29, 2021
    Configuration menu
    Copy the full SHA
    23f9b92 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f1372b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    aa1b127 View commit details
    Browse the repository at this point in the history
  4. Use correct edition when parsing :pat matchers

    As described in issue rust-lang#85708, we currently do not properly decode
    `SyntaxContext::root()` and `ExpnId::root()` from foreign crates. As a
    result, when we decode a span from a foreign crate with
    `SyntaxContext::root()`, we end up up considering it to have the edition
    of the *current* crate, instead of the foreign crate where it was
    originally created.
    
    A full fix for this issue will be a fairly significant undertaking.
    Fortunately, it's possible to implement a partial fix, which gives us
    the correct edition-dependent behavior for `:pat` matchers when the
    macro is loaded from another crate. Since we have the edition of the
    macro's defining crate available, we can 'recover' from seeing a
    `SyntaxContext::root()` and use the edition of the macro's defining
    crate.
    
    Any solution to issue rust-lang#85708 must reproduce the behavior of this
    targeted fix - properly preserving a foreign `SyntaxContext::root()`
    means (among other things) preserving its edition, which by definition
    is the edition of the foreign crate itself. Therefore, this fix moves us
    closer to the correct overall solution, and does not expose any new
    incorrect behavior to macros.
    Aaron1011 committed May 29, 2021
    Configuration menu
    Copy the full SHA
    d874ecc View commit details
    Browse the repository at this point in the history
  5. Fix a typo

    wooster0 authored May 29, 2021
    Configuration menu
    Copy the full SHA
    8d70f40 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b237f90 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2021

  1. Configuration menu
    Copy the full SHA
    b4148e9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    558b073 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#85285 - GuillaumeGomez:eslint-check, r=jsha…

    …,Mark-Simulacrum
    
    Add eslint checks to CI
    
    It also allowed me to fix some potential issues that went unnoticed. Having this process automated will hopefully prevent us to add more errors. :)
    
    cc `@Mark-Simulacrum` (for the add in the CI).
    r? `@jsha`
    GuillaumeGomez authored May 30, 2021
    Configuration menu
    Copy the full SHA
    9c873c1 View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#85709 - Aaron1011:fix-pat-crate-edition, r=…

    …petrochenkov
    
    Use correct edition when parsing `:pat` matchers
    
    As described in issue rust-lang#85708, we currently do not properly decode
    `SyntaxContext::root()` and `ExpnId::root()` from foreign crates. As a
    result, when we decode a span from a foreign crate with
    `SyntaxContext::root()`, we end up up considering it to have the edition
    of the *current* crate, instead of the foreign crate where it was
    originally created.
    
    A full fix for this issue will be a fairly significant undertaking.
    Fortunately, it's possible to implement a partial fix, which gives us
    the correct edition-dependent behavior for `:pat` matchers when the
    macro is loaded from another crate. Since we have the edition of the
    macro's defining crate available, we can 'recover' from seeing a
    `SyntaxContext::root()` and use the edition of the macro's defining
    crate.
    
    Any solution to issue rust-lang#85708 must reproduce the behavior of this
    targeted fix - properly preserving a foreign `SyntaxContext::root()`
    means (among other things) preserving its edition, which by definition
    is the edition of the foreign crate itself. Therefore, this fix moves us
    closer to the correct overall solution, and does not expose any new
    incorrect behavior to macros.
    GuillaumeGomez authored May 30, 2021
    Configuration menu
    Copy the full SHA
    bdd7062 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#85762 - mati865:disable-zlib-on-windows, r=…

    …Mark-Simulacrum
    
    Do not try to build LLVM with Zlib on Windows
    
    Fixes rust-lang#85422
    Fixes rust-lang#85624
    
    We do not install Zlib on the CI but recent builds somehow started picking it's shared version.
    To avoid relying on CI binaries so let's explicitly disable it.
    GuillaumeGomez authored May 30, 2021
    Configuration menu
    Copy the full SHA
    957badb View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#85770 - Bobo1239:set_locale_for_sort, r=jyn514

    Remove `--print unversioned-files` from rustdoc
    
    This flag isn't needed anymore. See rust-lang#83784.
    GuillaumeGomez authored May 30, 2021
    Configuration menu
    Copy the full SHA
    f7fb29b View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#85781 - badboy:document-aarch-ios-sim-suppo…

    …rt, r=Amanieu
    
    Add documentation for aarch64-apple-ios-sim target
    
    Documentation as requested for [MCP 428](rust-lang/compiler-team#428) to promote this target to Tier 2.
    
    Currently it calls out that it's Tier 3. That should be changed if this target is promoted, but this PR could also land before that.
    
    Note: probably should get signoff from the compiler team based on that MCP.
    GuillaumeGomez authored May 30, 2021
    Configuration menu
    Copy the full SHA
    2d30bc7 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#85801 - WaffleLapkin:master, r=joshtriplett

    Add `String::extend_from_within`
    
    This PR adds `String::extend_from_within` function under the `string_extend_from_within` feature gate similar to the [`Vec::extend_from_within`] function.
    
    ```rust
    // String
    pub fn extend_from_within<R>(&mut self, src: R)
    where
        R: RangeBounds<usize>;
    ```
    
    [`Vec::extend_from_within`]: rust-lang#81656
    GuillaumeGomez authored May 30, 2021
    Configuration menu
    Copy the full SHA
    b0f2a4c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    980a4a7 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#85818 - LeSeulArtichaut:85794-diag-drop-ice…

    …, r=petrochenkov
    
    Don't drop `PResult` without handling the error
    
    Fixes rust-lang#85794.
    GuillaumeGomez authored May 30, 2021
    Configuration menu
    Copy the full SHA
    71a7f8f View commit details
    Browse the repository at this point in the history