Add documentation for aarch64-apple-ios-sim target #85781
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
GuillaumeGomez
approved these changes
May 28, 2021
|
r? @Amanieu |
|
Oh, I just realized that the "Building Rust programs" are not valid as of right now, because target artifacts are not shipped. So right now users would need nightly + |
|
Please do so then. There is never too much clarity. :) |
This comment has been minimized.
This comment has been minimized.
|
Hm, I could fix the tier-check to also consider linked targets (which means hackily parsing markdown) or remove the link. |
|
Oh, actually, it's easier than that: We can just check for '`' somewhere in the line |
badboy
force-pushed
the
document-aarch-ios-sim-support
branch
from
7bf245b
to
1f3539b
Compare
This comment has been minimized.
This comment has been minimized.
badboy
force-pushed
the
document-aarch-ios-sim-support
branch
from
1f3539b
to
aa1b127
Compare
|
@bors r+ rollup |
|
📌 Commit aa1b127 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 30, 2021
…rt, r=Amanieu Add documentation for aarch64-apple-ios-sim target Documentation as requested for [MCP 428](rust-lang/compiler-team#428) to promote this target to Tier 2. Currently it calls out that it's Tier 3. That should be changed if this target is promoted, but this PR could also land before that. Note: probably should get signoff from the compiler team based on that MCP.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 30, 2021
…laumeGomez Rollup of 8 pull requests Successful merges: - rust-lang#85285 (Add eslint checks to CI) - rust-lang#85709 (Use correct edition when parsing `:pat` matchers) - rust-lang#85762 (Do not try to build LLVM with Zlib on Windows) - rust-lang#85770 (Remove `--print unversioned-files` from rustdoc ) - rust-lang#85781 (Add documentation for aarch64-apple-ios-sim target) - rust-lang#85801 (Add `String::extend_from_within`) - rust-lang#85817 (Fix a typo) - rust-lang#85818 (Don't drop `PResult` without handling the error) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documentation as requested for MCP 428 to promote this target to Tier 2.
Currently it calls out that it's Tier 3. That should be changed if this target is promoted, but this PR could also land before that.
Note: probably should get signoff from the compiler team based on that MCP.