Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Remove * intra-doc alias for pointer #80892

Merged
merged 1 commit into from
Jan 11, 2021

Conversation

camelid
Copy link
Member

@camelid camelid commented Jan 10, 2021

It's not valid Rust code and it can easily be confused with a wildcard
glob pattern or something else. People can always use pointer instead,
so it's just removing an alias.

It hasn't hit stable yet (I think it's still on nightly), so it's okay
to remove it. (We can always add it back later if we change our mind
too.)

r? @jyn514
cc #80885 (comment)

It's not valid Rust code and it can easily be confused with a wildcard
glob pattern or something else. People can always use `pointer` instead,
so it's just removing an alias.

It hasn't hit stable yet (I think it's still on nightly), so it's okay
to remove it. (We can always add it back later if we change our mind
too.)
@camelid camelid added A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jan 10, 2021
@rust-highfive
Copy link
Collaborator

Some changes occurred in intra-doc-links.

cc @jyn514

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2021
@jyn514
Copy link
Member

jyn514 commented Jan 11, 2021

@bors r+

@bors
Copy link
Contributor

bors commented Jan 11, 2021

📌 Commit e98f11b has been approved by jyn514

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 11, 2021
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2021
Rollup of 6 pull requests

Successful merges:

 - rust-lang#80809 (Use standard formatting for "rust-call" ABI message)
 - rust-lang#80872 (Fix typo in source-based-code-coverage.md)
 - rust-lang#80878 (Add ABI argument to `find_mir_or_eval_fn`)
 - rust-lang#80881 ( Fix intra-doc links to `Self` and `crate` )
 - rust-lang#80887 (log-color: Detect TTY based on stderr, not stdout)
 - rust-lang#80892 (rustdoc: Remove `*` intra-doc alias for `pointer`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a7f7d70 into rust-lang:master Jan 11, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 11, 2021
@bors
Copy link
Contributor

bors commented Jan 11, 2021

⌛ Testing commit e98f11b with merge a2cd91c...

@camelid camelid deleted the intra-doc-remove-star branch January 11, 2021 21:17
@camelid
Copy link
Member Author

camelid commented Jan 11, 2021

Wow, another race condition!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants