Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix intra-doc links to Self and crate #80881

Merged
merged 2 commits into from
Jan 11, 2021
Merged

Fix intra-doc links to Self and crate #80881

merged 2 commits into from
Jan 11, 2021

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented Jan 10, 2021

Closes #77732.

@jyn514 jyn514 added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name labels Jan 10, 2021
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive
Copy link
Collaborator

r? @GuillaumeGomez

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 10, 2021
@GuillaumeGomez
Copy link
Member

Thanks! r=me once CI pass

@jyn514
Copy link
Member Author

jyn514 commented Jan 10, 2021

@bors r=GuillaumeGomez

@bors
Copy link
Contributor

bors commented Jan 10, 2021

📌 Commit a52341d has been approved by GuillaumeGomez

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 10, 2021
@JohnTitor JohnTitor mentioned this pull request Jan 11, 2021
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 11, 2021
@bors
Auto merge of rust-lang#80905 - JohnTitor:rollup-tmmwmnb, r=JohnTitor
a2cd91c 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#80809 (Use standard formatting for "rust-call" ABI message)
 - rust-lang#80872 (Fix typo in source-based-code-coverage.md)
 - rust-lang#80878 (Add ABI argument to `find_mir_or_eval_fn`)
 - rust-lang#80881 ( Fix intra-doc links to `Self` and `crate` )
 - rust-lang#80887 (log-color: Detect TTY based on stderr, not stdout)
 - rust-lang#80892 (rustdoc: Remove `*` intra-doc alias for `pointer`)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Jan 11, 2021

⌛ Testing commit a52341d with merge a2cd91c...

@bors bors merged commit 6e2249d into rust-lang:master Jan 11, 2021
@rustbot rustbot added this to the 1.51.0 milestone Jan 11, 2021
@jyn514 jyn514 deleted the intra-doc-self branch January 11, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez approved these changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
A-intra-doc-links Area: Intra-doc links, the ability to link to items in docs by name S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.51.0
Development

Successfully merging this pull request may close these issues.

Self on its own does not resolve in intra-doc links
5 participants
@jyn514 @rust-highfive @GuillaumeGomez @bors @rustbot