Rollup of 11 pull requests #79220
Merged
Rollup of 11 pull requests #79220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was noticed while we were updating the embedded rust book: https://github.com/rust-embedded/book/pull/273/files These targets do natively have atomic load/stores, but do not support CAS operations.
We already set `compiletest` to use the local sysroot in rust-lang#68019, but that missed the configuration for testing `compiletest` itself.
This reverts commit 99be78d.
This reverts commit d486bfc.
Collect derive placeholders using `collect` instead of `push`
Clarify availability of atomic operations This was noticed while we were updating the embedded rust book: https://github.com/rust-embedded/book/pull/273/files These targets do natively have atomic load/stores, but do not support CAS operations.
Add u128 and i128 integer tests Add the missing integer tests for u128 and i128 for completeness with the other integer types.
Test drop order for (destructuring) assignments Add a test that checks whether the drop order of `let` bindings is consistent with the drop order of the corresponding destructuring assignments. Thanks to ```@RalfJung``` for the suggesting this test ([here](rust-lang#79016 (comment))) and an implementation! r? ```@RalfJung```
…e-link, r=jyn514,GuillaumeGomez rustdoc: add [src] links to methods on a trait's page Closes rust-lang#45150  ### Caveats - The way I've implemented it, links are also provided for required methods, that just link to the signature in the code. I'm not sure if this is the desired behaviour.  - I'm not sure if the css changes are correct. I inspected them visualy on firefox on desktop, and they seem to be fine. - I can't tell how `src/librustdoc/html/render/mod.rs` is structured, so I probably
…=Mark-Simulacrum Make compiletest testing use the local sysroot We already set `compiletest` to use the local sysroot in rust-lang#68019, but that missed the configuration for testing `compiletest` itself.
expand/resolve: Pre-requisites to "Turn `#[derive]` into a regular macro attribute" Miscellaneous refactorings and error reporting changes extracted from rust-lang#79078. Unlike rust-lang#79078 this PR doesn't make any observable changes to the language or library. r? ```@Aaron1011```
…avidtwco Revert rust-lang#78969 "Normalize function type during validation" Closes rust-lang#79066. Reopens rust-lang#78442.
…tmcm
Make as{_mut,}_slice on array::IntoIter public
The functions are useful in cases where you want to move data out of the IntoIter in bulk, by transmute_copy'ing the slice and then forgetting the IntoIter.
In the compiler, this is useful for providing a sped up IntoIter implementation. One can alternatively provide a separate allocate_array function but one can avoid duplicating some logic by passing everything through the generic iterator using interface.
As per suggestion in https://github.com/rust-lang/rust/pull/78569/files#r526506964
Add jyn514 email alias to mailmap r? ```@jyn514```
…chievink Move `rustc_ty` -> `rustc_ty_utils` Implements MCP rust-lang/compiler-team#387. r? `@jonas-schievink`
…r=Mark-Simulacrum Add the "memcpy" doc alias to slice::copy_from_slice [RFC1419](rust-lang/rfcs#1419) describes `slice::copy_from_slice` as a "safe memcpy". This enables people searching for `memcpy` to find the `slice::copy_from_slice` method. Thanks! ## Screenshots This is currently the output when searching for "memcpy" -- `copy_from_slice` is safe, and should be part of this list. 
|
@bors r+ rollup=never p=5 |
|
📌 Commit 5adc00f has been approved by |
bors
added
the
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
This was referenced Nov 20, 2020
|
This was a moderate improvement in instruction counts (up to -3.3% on cc @tmiasko, not sure if 'congratulations' are in order, but it was definitely an improvement :) Maybe this is something to keep an eye on when you re-enable that validation? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
#[derive]into a regular macro attribute" #79185 (expand/resolve: Pre-requisites to "Turn#[derive]into a regular macro attribute")rustc_ty->rustc_ty_utils#79212 (Moverustc_ty->rustc_ty_utils)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup