Test drop order for (destructuring) assignments #79177
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
jyn514
added
the
A-testsuite
|
Thanks! |
|
📌 Commit 1094f97 has been approved by |
bors
added
S-waiting-on-bors
varkor
added
the
F-destructuring_assignment
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 19, 2020
Test drop order for (destructuring) assignments Add a test that checks whether the drop order of `let` bindings is consistent with the drop order of the corresponding destructuring assignments. Thanks to `@RalfJung` for the suggesting this test ([here](rust-lang#79016 (comment))) and an implementation! r? `@RalfJung`
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Nov 19, 2020
Test drop order for (destructuring) assignments Add a test that checks whether the drop order of `let` bindings is consistent with the drop order of the corresponding destructuring assignments. Thanks to ``@RalfJung`` for the suggesting this test ([here](rust-lang#79016 (comment))) and an implementation! r? ``@RalfJung``
This was referenced Nov 19, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 20, 2020
Rollup of 11 pull requests Successful merges: - rust-lang#79119 (Clarify availability of atomic operations) - rust-lang#79123 (Add u128 and i128 integer tests) - rust-lang#79177 (Test drop order for (destructuring) assignments) - rust-lang#79181 (rustdoc: add [src] links to methods on a trait's page) - rust-lang#79183 (Make compiletest testing use the local sysroot) - rust-lang#79185 (expand/resolve: Pre-requisites to "Turn `#[derive]` into a regular macro attribute") - rust-lang#79193 (Revert rust-lang#78969 "Normalize function type during validation") - rust-lang#79194 (Make as{_mut,}_slice on array::IntoIter public) - rust-lang#79204 (Add jyn514 email alias to mailmap) - rust-lang#79212 (Move `rustc_ty` -> `rustc_ty_utils`) - rust-lang#79217 (Add the "memcpy" doc alias to slice::copy_from_slice) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a test that checks whether the drop order of
letbindings is consistent with the drop order of the corresponding destructuring assignments.Thanks to @RalfJung for the suggesting this test (here) and an implementation!
r? @RalfJung