Only skip impls of foreign unstable traits #74534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously unstable impls were skipped, which meant that any impl with an unstable method would get skipped.
|
r? @ollie27 (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
jyn514
reviewed
Jul 19, 2020
|
Yes, and I confirmed that at least std::panic::Location builds with all methods included, and I couldn't find any stray impls on u32 with the patch (which was the reason for the start of it in the first place). |
|
@bors r+ p=1 yeah this looks just about what I'd expect that patch to be |
|
📌 Commit e24a017 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#73618 (Documentation for the false keyword) - rust-lang#74486 (Improve Read::read_exact documentation) - rust-lang#74514 (Do not clobber RUSTDOCFLAGS) - rust-lang#74516 (do not try fetching the ancestors of errored trait impls) - rust-lang#74520 (include backtrace folder in rust-src component) - rust-lang#74523 (Improve documentation for `core::fmt` internals) - rust-lang#74527 (Add myself to toolstate change notifications for rustfmt) - rust-lang#74534 (Only skip impls of foreign unstable traits) - rust-lang#74536 (fix documentation surrounding the `in` and `for` keywords) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously unstable impls were skipped, which meant that any impl with an unstable method would get skipped.
Fixes #74531.