Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add STILL_FURTHER_SPECIALIZABLE flag #70658

Merged

Conversation

davidtwco
Copy link
Member

Contributes to #70285.

This PR adds a STILL_FURTHER_SPECIALIZABLE flag to TypeFlags
which replaces needs_infer and needs_subst in Instance::resolve
and assemble_candidates_from_impls.

r? @eddyb

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 1, 2020
eddyb
eddyb previously requested changes Apr 1, 2020
Copy link
Member

@eddyb eddyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me after taking out the closure/generator changes, and replacing the comment. cc @nikomatsakis

src/librustc_middle/ty/flags.rs Outdated Show resolved Hide resolved
src/librustc_middle/ty/flags.rs Outdated Show resolved Hide resolved
src/librustc_middle/ty/fold.rs Outdated Show resolved Hide resolved
src/librustc_middle/ty/sty.rs Outdated Show resolved Hide resolved
src/librustc_middle/ty/sty.rs Show resolved Hide resolved
@davidtwco davidtwco force-pushed the issue-70285-still-further-specializable branch from b99a903 to 9ef60be Compare April 1, 2020 15:22
@eddyb
Copy link
Member

eddyb commented Apr 1, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 1, 2020

📌 Commit 9ef60be001165a3c7e23ba3015ed82e25990d38a has been approved by eddyb

@bors
Copy link
Contributor

bors commented Apr 1, 2020

🌲 The tree is currently closed for pull requests below priority 500, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2020
@bors

This comment has been minimized.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 1, 2020
@davidtwco davidtwco force-pushed the issue-70285-still-further-specializable branch from 9ef60be to 3daff36 Compare April 2, 2020 09:17
src/librustc_middle/ty/mod.rs Outdated Show resolved Hide resolved
This commit adds a STILL_FURTHER_SPECIALIZABLE flag to `TypeFlags`
which replaces `needs_infer` and `needs_subst` in `Instance::resolve`
and `assemble_candidates_from_impls.`

Signed-off-by: David Wood <[email protected]>
@davidtwco davidtwco force-pushed the issue-70285-still-further-specializable branch from 3daff36 to c665eae Compare April 2, 2020 09:50
@eddyb
Copy link
Member

eddyb commented Apr 2, 2020

@bors r+

@bors
Copy link
Contributor

bors commented Apr 2, 2020

📌 Commit c665eae has been approved by eddyb

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 2, 2020
Centril added a commit to Centril/rust that referenced this pull request Apr 2, 2020
…-specializable, r=eddyb

add `STILL_FURTHER_SPECIALIZABLE` flag

Contributes to rust-lang#70285.

This PR adds a `STILL_FURTHER_SPECIALIZABLE` flag to `TypeFlags`
which replaces `needs_infer` and `needs_subst` in `Instance::resolve`
and `assemble_candidates_from_impls`.

r? @eddyb
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#70281 (Implement Hash for Infallible)
 - rust-lang#70421 (parse: recover on `const fn()` / `async fn()`)
 - rust-lang#70615 (Renamed `PerDefTables` to `Tables`)
 - rust-lang#70631 (Update cargo)
 - rust-lang#70634 (Remove some reexports in `rustc_middle`)
 - rust-lang#70658 (add `STILL_FURTHER_SPECIALIZABLE` flag)
 - rust-lang#70678 (Add missing markdown rust annotation)
 - rust-lang#70681 (Handle unterminated raw strings with no #s properly)

Failed merges:

r? @ghost
@bors bors merged commit 857942e into rust-lang:master Apr 2, 2020
@davidtwco davidtwco deleted the issue-70285-still-further-specializable branch April 10, 2020 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants