Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renamed PerDefTables to Tables #70615

Merged
merged 1 commit into from
Apr 2, 2020
Merged

Renamed PerDefTables to Tables #70615

merged 1 commit into from
Apr 2, 2020

Conversation

Lezzz
Copy link
Contributor

@Lezzz Lezzz commented Mar 31, 2020

Originally suggested by @eddyb

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ecstatic-morse (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 31, 2020
@@ -585,7 +585,7 @@ impl<'tcx> EncodeContext<'tcx> {
println!(" def-path table bytes: {}", def_path_table_bytes);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not relevant to this PR necessarily but we should probably encode the DefPathTable as an actual Table.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Harder to do without splitting DefPathTable into several tables, though.

@ecstatic-morse
Copy link
Contributor

r? @eddyb

@rust-highfive rust-highfive assigned eddyb and unassigned ecstatic-morse Apr 1, 2020
@eddyb
Copy link
Member

eddyb commented Apr 1, 2020

r? @oli-obk

@rust-highfive rust-highfive assigned oli-obk and unassigned eddyb Apr 1, 2020
@oli-obk
Copy link
Contributor

oli-obk commented Apr 2, 2020

@bors r+

This was much more self-contained than I would have thought from the title.

@bors
Copy link
Contributor

bors commented Apr 2, 2020

📌 Commit dca3782 has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 2, 2020
Centril added a commit to Centril/rust that referenced this pull request Apr 2, 2020
Renamed `PerDefTables` to `Tables`

Originally suggested by @eddyb
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 2, 2020
Rollup of 8 pull requests

Successful merges:

 - rust-lang#70281 (Implement Hash for Infallible)
 - rust-lang#70421 (parse: recover on `const fn()` / `async fn()`)
 - rust-lang#70615 (Renamed `PerDefTables` to `Tables`)
 - rust-lang#70631 (Update cargo)
 - rust-lang#70634 (Remove some reexports in `rustc_middle`)
 - rust-lang#70658 (add `STILL_FURTHER_SPECIALIZABLE` flag)
 - rust-lang#70678 (Add missing markdown rust annotation)
 - rust-lang#70681 (Handle unterminated raw strings with no #s properly)

Failed merges:

r? @ghost
@bors bors merged commit f355997 into rust-lang:master Apr 2, 2020
@Lezzz Lezzz deleted the rename-tables branch August 3, 2020 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants