Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #69931

Closed
wants to merge 37 commits into from
Closed

Commits on Jan 11, 2020

  1. Added tvOS as a backend

    simlay committed Jan 11, 2020
    Configuration menu
    Copy the full SHA
    35c4aae View commit details
    Browse the repository at this point in the history

Commits on Feb 14, 2020

  1. Configuration menu
    Copy the full SHA
    a266169 View commit details
    Browse the repository at this point in the history

Commits on Feb 15, 2020

  1. Configuration menu
    Copy the full SHA
    6b17330 View commit details
    Browse the repository at this point in the history

Commits on Feb 20, 2020

  1. fmt

    Sebastian Imlay committed Feb 20, 2020
    Configuration menu
    Copy the full SHA
    2599771 View commit details
    Browse the repository at this point in the history

Commits on Mar 4, 2020

  1. Configuration menu
    Copy the full SHA
    0e1cd59 View commit details
    Browse the repository at this point in the history
  2. more toolstate comments

    RalfJung authored and ehuss committed Mar 4, 2020
    Configuration menu
    Copy the full SHA
    a6d8c9c View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a41f1f1 View commit details
    Browse the repository at this point in the history

Commits on Mar 5, 2020

  1. Configuration menu
    Copy the full SHA
    91525fd View commit details
    Browse the repository at this point in the history
  2. review comments

    estebank committed Mar 5, 2020
    Configuration menu
    Copy the full SHA
    713a291 View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2020

  1. Configuration menu
    Copy the full SHA
    3d146a3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6fba412 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    005fc6e View commit details
    Browse the repository at this point in the history
  4. review comment

    estebank committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    f483032 View commit details
    Browse the repository at this point in the history

Commits on Mar 8, 2020

  1. Configuration menu
    Copy the full SHA
    4897594 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. Configuration menu
    Copy the full SHA
    8a8870f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    911c75f View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2020

  1. Configuration menu
    Copy the full SHA
    0037f4e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9d4fdba View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1ddcea3 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d00b269 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b3b32b7 View commit details
    Browse the repository at this point in the history

Commits on Mar 11, 2020

  1. review comments

    estebank committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    29be741 View commit details
    Browse the repository at this point in the history
  2. Compute the correct layout for variants of uninhabited enums and read…

    …d a long lost assertion
    
    This reverts part of commit 9712fa4.
    oli-obk committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    cdc7304 View commit details
    Browse the repository at this point in the history
  3. Comment nits

    Co-Authored-By: Ralf Jung <[email protected]>
    oli-obk and RalfJung authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    ec88ffa View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    3244c84 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    74608c7 View commit details
    Browse the repository at this point in the history
  6. review comments

    estebank committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7ee1b47 View commit details
    Browse the repository at this point in the history
  7. ci: bump webrender in cargotest

    This bumps the commit of webrender we test to include a fix for a
    spurious failure we encountered in CI. See rust-lang#69895 for more context on
    the spurious failure.
    pietroalbini committed Mar 11, 2020
    Configuration menu
    Copy the full SHA
    bbafe47 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#68191 - simlay:add-tvSO-target, r=nagisa

    Added tvOS as targets
    
    This is a first attempt of adding support tvOS as described in rust-lang#48862. It's got a lot of overlap with [src/librustc_target/spec/apple_ios_base.rs](https://github.com/rust-lang/rust/blob/31dd4f4acbcbdb02b0745d2136399ed664a28050/src/librustc_target/spec/apple_ios_base.rs).
    
    I thought about refactoring `apple_ios_base.rs` to include this as well but that would require each of the ios and tvos targets to be of the something like the form `let base = opts(AppleOS::TV, Arch::Arm64)?;` I also did the same thing for watchOS because from what I can tell, all three targets (iOS, tvOS, and watchOS) have the same logic but have different parameters being sent to `xcrun`. Thoughts?
    
    As far as the `data_layout` and other parameters to `Target`, I did as much research as I could but it really seems that processor in the [iPhone 11 is the same as the apple TV](https://en.wikipedia.org/wiki/Apple-designed_processors) so I didn't change any of those parameters.
    
    I did get this to build and tested that it's actually running the the below logic (because the parameter to `xcrun` is `appletvos` not `tvos`).
    
    I didn't manage to get it to actually compile a file with `fn main(){}` because I don't have the stdlib for `aarch64-apple-tvos` compiled it seems. Is there documentation for this?
    
    Similar to the ending of rust-lang#63467, I'm not sure what to do next.
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    37e967f View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#69011 - foeb:document-unsafe-core-fmt, r=Ma…

    …rk-Simulacrum
    
    Document unsafe blocks in core::fmt
    
    r? @RalfJung
    CC: @rust-lang/wg-unsafe-code-guidelines
    rust-lang#66219
    
    Sorry for the hiatus, but here's a few more files with the unsafe blocks documented! I think working on it smaller chunks like this will be easier for everyone.
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    d839de9 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#69705 - ehuss:toolstate-remove-redundant-be…

    …ta, r=Mark-Simulacrum
    
    Toolstate: remove redundant beta-week check.
    
    I made a bit of a mistake in rust-lang#69624.  The "beta regression" doesn't need to be checked twice.
    
    I also rolled up rust-lang#69693 to avoid merge conflicts.
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    9381b8b View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#69722 - estebank:negative-impl-span-ast, r=…

    …Centril
    
    Tweak output for invalid negative impl AST errors
    
    Use more accurate spans for negative `impl` errors.
    
    r? @Centril
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3681df6 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#69747 - spastorino:rename-rustc-guide, r=pi…

    …etroalbini
    
    Rename rustc guide
    
    This is in preparation for rust-lang/rustc-dev-guide#470
    Needs to be merged after we actually rename the guide.
    
    Have used this to rename:
    
    `git grep -l 'rustc_guide' | xargs sed -i 's/rustc_guide/rustc_dev_guide/g'`
    `git grep -l 'rustc-guide' | xargs sed -i 's/rustc-guide/rustc-dev-guide/g'`
    `git grep -l 'rustc guide' | xargs sed -i 's/rustc guide/rustc dev guide/g'`
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    e10e6f0 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#69768 - oli-obk:union_field_ice, r=eddyb,Ra…

    …lfJung
    
    Compute the correct layout for variants of uninhabited enums
    
    r? @eddyb
    cc @RalfJung
    
    fixes rust-lang#69191
    cc rust-lang#69763
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    7210c6c View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#69830 - RalfJung:miri-invalid-terminator, r…

    …=oli-obk
    
    miri: ICE on invalid terminators
    
    We've run a lot of MIR in Miri (including some generators) and never seen these.
    
    @tmandry is it correct that `Yield` and `GeneratorDrop` get lowered away?
    
    @eddyb @oli-obk what's with this `Abort` that does not seem to ever actually exist? Codegen *does* seem to handle it, so I wonder why Miri can get away without that. In fact, codegen handles it twice:
    
    https://github.com/rust-lang/rust/blob/1d5241c96208ca7d925442b1a5fa45ad18717a6f/src/librustc_codegen_ssa/mir/block.rs#L796
    
    https://github.com/rust-lang/rust/blob/1d5241c96208ca7d925442b1a5fa45ad18717a6f/src/librustc_codegen_ssa/mir/mod.rs#L296
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    75429bc View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#69921 - matthiaskrgr:rustdoc_import, r=Centril

    rustdoc: remove unused import
    
    ```
        Checking rustdoc v0.0.0 (/home/matthias/vcs/github/rust/src/librustdoc)
    warning: unused import: `rustc_span::symbol::sym`
      --> src/librustdoc/clean/inline.rs:15:5
       |
    15 | use rustc_span::symbol::sym;
       |     ^^^^^^^^^^^^^^^^^^^^^^^
       |
       = note: `#[warn(unused_imports)]` on by default
    ```
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    855e79a View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#69928 - pietroalbini:bump-cargotest-webrend…

    …er, r=Mark-Simulacrum
    
    ci: bump webrender in cargotest
    
    This bumps the commit of webrender we test to include a fix for a spurious failure we encountered in CI. See rust-lang#69895 for more context on the spurious failure.
    
    The commit we're interested in including is servo/webrender@07439c5. Thanks again @jrmuizel for the quick response on this!
    
    r? @Mark-Simulacrum
    Centril authored Mar 11, 2020
    Configuration menu
    Copy the full SHA
    3002bd2 View commit details
    Browse the repository at this point in the history