Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: bump webrender in cargotest #69928

Closed
wants to merge 1 commit into from
Closed

ci: bump webrender in cargotest #69928

wants to merge 1 commit into from

Conversation

pietroalbini
Copy link
Member

This bumps the commit of webrender we test to include a fix for a spurious failure we encountered in CI. See #69895 for more context on the spurious failure.

The commit we're interested in including is servo/webrender@07439c5. Thanks again @jrmuizel for the quick response on this!

r? @Mark-Simulacrum

@pietroalbini
ci: bump webrender in cargotest
bbafe47 
This bumps the commit of webrender we test to include a fix for a
spurious failure we encountered in CI. See rust-lang#69895 for more context on
the spurious failure.
@rust-highfive
Copy link
Collaborator

Updates src/tools/cargo.

cc @ehuss

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 11, 2020
@pietroalbini pietroalbini linked an issue Mar 11, 2020 that may be closed by this pull request
Spurious WebRender failure: 'gperf' is missing on your system #69895
Closed
@ehuss ehuss mentioned this pull request Mar 11, 2020
Closed
@Mark-Simulacrum
Copy link
Member

Seems good to me.

@bors r+

@bors
Copy link
Contributor

bors commented Mar 11, 2020

📌 Commit bbafe47 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2020
Centril added a commit to Centril/rust that referenced this pull request Mar 11, 2020
@Centril
Rollup merge of rust-lang#69928 - pietroalbini:bump-cargotest-webrend…
3002bd2 
…er, r=Mark-Simulacrum

ci: bump webrender in cargotest

This bumps the commit of webrender we test to include a fix for a spurious failure we encountered in CI. See rust-lang#69895 for more context on the spurious failure.

The commit we're interested in including is servo/webrender@07439c5. Thanks again @jrmuizel for the quick response on this!

r? @Mark-Simulacrum
@Centril Centril mentioned this pull request Mar 11, 2020
Closed
@goffrie
Copy link
Contributor

goffrie commented Mar 12, 2020

Looks like this caused #69931 to fail:

2020-03-11T22:40:47.7996438Z error: failed to run custom build command for `compositor-windows v0.1.0 (D:\a\1\s\build\ct\webrender\example-compositor\compositor-windows)`
2020-03-11T22:40:47.7997526Z 
2020-03-11T22:40:47.7997853Z Caused by:
2020-03-11T22:40:47.7998491Z   process didn't exit successfully: `D:\a\1\s\build\ct\webrender\target\debug\build\compositor-windows-a42f9fe4a6ab9aa2\build-script-build` (exit code: 101)
2020-03-11T22:40:47.7999145Z --- stdout
2020-03-11T22:40:47.7999502Z TARGET = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.7999847Z OPT_LEVEL = Some("0")
2020-03-11T22:40:47.8000230Z TARGET = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.8000607Z HOST = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.8001023Z TARGET = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.8001472Z TARGET = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.8001845Z HOST = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.8002234Z CC_x86_64-pc-windows-msvc = None
2020-03-11T22:40:47.8002580Z CC_x86_64_pc_windows_msvc = None
2020-03-11T22:40:47.8002996Z HOST_CC = None
2020-03-11T22:40:47.8003256Z CC = None
2020-03-11T22:40:47.8003510Z TARGET = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.8003847Z HOST = Some("x86_64-pc-windows-msvc")
2020-03-11T22:40:47.8004478Z CFLAGS_x86_64-pc-windows-msvc = None
2020-03-11T22:40:47.8004863Z CFLAGS_x86_64_pc_windows_msvc = None
2020-03-11T22:40:47.8005128Z HOST_CFLAGS = None
2020-03-11T22:40:47.8005401Z CFLAGS = None
2020-03-11T22:40:47.8005670Z DEBUG = Some("true")
2020-03-11T22:40:47.8006518Z running: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\VC\\Tools\\MSVC\\14.16.27023\\bin\\HostX64\\x64\\cl.exe" "/nologo" "/MD" "/Z7" "/I" "../../../angle/checkout/include" "/W4" "/FoD:\\a\\1\\s\\build\\ct\\webrender\\target\\debug\\build\\compositor-windows-4a6bb37668b71e84\\out\\src/lib.o" "/c" "src/lib.cpp"
2020-03-11T22:40:47.8007284Z lib.cpp
2020-03-11T22:40:47.8007702Z src/lib.cpp(20): fatal error C1083: Cannot open include file: 'EGL/egl.h': No such file or directory
2020-03-11T22:40:47.8008086Z exit code: 2

@pietroalbini
Copy link
Member Author

@bors r-

Legit.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 12, 2020
@Kixiron Kixiron added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 16, 2020
@JohnTitor JohnTitor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2020
@joelpalmer joelpalmer added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 30, 2020
@pietroalbini
Copy link
Member Author

Superseded by #70626.

@pietroalbini pietroalbini deleted the bump-cargotest-webrender branch March 31, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Spurious WebRender failure: 'gperf' is missing on your system
8 participants
@pietroalbini @rust-highfive @Mark-Simulacrum @bors @goffrie @joelpalmer @JohnTitor @Kixiron