Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

naive startswith can cover wrong directories for "mentions" #253

Closed
ehuss opened this issue Mar 11, 2020 · 1 comment · Fixed by #301
Closed

naive startswith can cover wrong directories for "mentions" #253

ehuss opened this issue Mar 11, 2020 · 1 comment · Fixed by #301

Comments

@ehuss
Copy link
Contributor

ehuss commented Mar 11, 2020

Noticed in rust-lang/rust#69928 (comment), the entry src/tools/cargo also matches src/tools/cargotest.

Perhaps it should only match full-components? (Similar to how Rust's starts_with works.)
@pietroalbini
Copy link
Member

Yep, this is just a bug.

@ehuss ehuss mentioned this issue Oct 2, 2020
Merged
@ehuss ehuss mentioned this issue Dec 7, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't use startswith when comparing mentions paths. ehuss/highfive
2 participants
@ehuss @pietroalbini