Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove event that causes panics in measureme tools #65137

Merged
merged 1 commit into from
Oct 7, 2019
Merged

remove event that causes panics in measureme tools #65137

merged 1 commit into from
Oct 7, 2019

Conversation

andjo403
Copy link
Contributor

@andjo403 andjo403 commented Oct 5, 2019

the measureme tools summarize and crox do not alow a event to go out of scope of the parent event

codegen_and_optimize_crate ends after the codegen_crate event

r? @wesleywiser
cc @michaelwoerister @Mark-Simulacrum

@andjo403
remove event that causes panics in measureme tools
993e3a5 
the measureme tools summarize and crox do not alow a event to go out of scope of the parent event

codegen_and_optimize_crate ends after the codegen_crate event
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2019
This was referenced Oct 5, 2019
Merged
Merged
@michaelwoerister
Copy link
Member

Thanks for the PR, @andjo403! I want to make this work but for now let's unbreak the summarize tool.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2019

📌 Commit 993e3a5 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 7, 2019
@michaelwoerister
Copy link
Member

@bors p=1 (because it unbreaks perf.rlo)

Centril added a commit to Centril/rust that referenced this pull request Oct 7, 2019
@Centril
Rollup merge of rust-lang#65137 - andjo403:selfProfiling_fix, r=micha…
3a1f8df 
…elwoerister

remove event that causes panics in measureme tools

the measureme tools summarize and crox do not alow a event to go out of scope of the parent event

codegen_and_optimize_crate ends after the codegen_crate event

r? @wesleywiser
cc @michaelwoerister @Mark-Simulacrum
@Centril Centril mentioned this pull request Oct 7, 2019
Merged
bors added a commit that referenced this pull request Oct 7, 2019
@bors
Auto merge of #65178 - Centril:rollup-ep1zztj, r=Centril
e3cb9ea 
Rollup of 4 pull requests

Successful merges:

 - #63948 (Add feature gate for raw_dylib.)
 - #65137 (remove event that causes panics in measureme tools)
 - #65164 (Add long error explanation for E0566)
 - #65173 (Update reference)

Failed merges:

r? @ghost
@bors bors merged commit 993e3a5 into rust-lang:master Oct 7, 2019
@wesleywiser
Copy link
Member

Thanks @andjo403 for tracking this down and thanks @michaelwoerister for reviewing!

@andjo403 andjo403 mentioned this pull request Oct 10, 2019
Closed
@andjo403 andjo403 deleted the selfProfiling_fix branch October 10, 2019 16:35
@wesleywiser wesleywiser mentioned this pull request Oct 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@michaelwoerister michaelwoerister

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@andjo403 @michaelwoerister @bors @wesleywiser @rust-highfive