Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add feature gate for raw_dylib. #63948

Merged
merged 5 commits into from
Oct 7, 2019
Merged

Add feature gate for raw_dylib. #63948

merged 5 commits into from
Oct 7, 2019

Conversation

crlf0710
Copy link
Member

@crlf0710 crlf0710 commented Aug 27, 2019 •
edited by Centril
Loading

This PR adds the feature gate for RFC 2627 (#58713). It doesn't contain the actual functionality.
Add I'm not sure whether i did it correctly, since this is the first time i did this.

r? @Centril

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 27, 2019
@rust-highfive

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril Centril added the F-raw_dylib `#![feature(raw_dylib)]` label Aug 27, 2019
@Centril
Copy link
Contributor

Centril commented Aug 27, 2019

r? @nagisa cc @retep998 @joshtriplett

@rust-highfive rust-highfive assigned nagisa and unassigned Centril Aug 27, 2019
@crlf0710 crlf0710 force-pushed the path_to_raw_dylib branch 2 times, most recently from c4abdb8 to 9fdbcb3 Compare August 27, 2019 19:32
@joshtriplett
Copy link
Member

LGTM

@retep998
Copy link
Member

Well, at least it is some sort of progress. Nothing here that I can test or review yet.

nagisa
nagisa reviewed Aug 30, 2019
View reviewed changes
Copy link
Member

@nagisa nagisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The gate implementation looks right, however to the best of my knowledge we avoid merging PRs that are not self-contained (as would be the case with this PR) as that may lead to dead code if the remaining changes are never made.

@crlf0710
Copy link
Member Author

I'm happy to implement more or even all of the RFC if i can. But i guess i need some mentoring, especially on the codegen part.
Welcome to leave notes on https://rust-lang.zulipchat.com/#narrow/stream/182449-t-compiler.2Fhelp/topic/Sketching.20out.20a.20plan.20for.20implementing.20RFC.202627 . I appreciate your help :)

@Centril
Copy link
Contributor

Centril commented Aug 30, 2019

The gate implementation looks right, however to the best of my knowledge we avoid merging PRs that are not self-contained (as would be the case with this PR) as that may lead to dead code if the remaining changes are never made.

@nagisa Shouldn't be too hard to remove things if the other changes are never made in this case. We have an INCOMPLETE_FEATURES list in active.rs for features in a similar situation.

@JohnCSimon JohnCSimon added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 7, 2019
@JohnCSimon

This comment has been minimized.

Sign in to view
@crlf0710

This comment has been minimized.

Sign in to view
@crlf0710

This comment has been minimized.

Sign in to view
@joshtriplett
Copy link
Member

This looks entirely reasonable to me, and seems like a good start for further implementation.

I think it's up to someone other than me whether we want to merge a commit that provides the skeleton of support like this, but personally I think it's a good idea.

Centril
Centril reviewed Sep 9, 2019
View reviewed changes
src/libsyntax/feature_gate/builtin_attrs.rs Show resolved Hide resolved
src/libsyntax/feature_gate/builtin_attrs.rs Show resolved Hide resolved
src/test/ui/feature-gates/feature-gate-raw-dylib-2.rs Outdated Show resolved Hide resolved
src/test/ui/feature-gates/feature-gate-raw-dylib-2.rs Outdated Show resolved Hide resolved
src/libsyntax/feature_gate/active.rs Outdated Show resolved Hide resolved
src/librustc_typeck/collect.rs Outdated Show resolved Hide resolved
src/librustc_typeck/collect.rs Outdated Show resolved Hide resolved
src/librustc_typeck/collect.rs Outdated Show resolved Hide resolved
src/librustc_typeck/collect.rs Outdated Show resolved Hide resolved
src/librustc/middle/cstore.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Sep 9, 2019

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned nagisa Sep 9, 2019
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Oct 6, 2019

Looks like legit rebase fallout from the node -> kind PR. Can you fix it?

@Centril Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 6, 2019
@crlf0710
Copy link
Member Author

crlf0710 commented Oct 6, 2019

Sure

@Centril
Copy link
Contributor

Centril commented Oct 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2019

📌 Commit c223f5afb87ad3efac10359b941fe492f756a91f has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2019
@bors

This comment has been minimized.

Sign in to view
@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 7, 2019
@bors

This comment has been minimized.

Sign in to view
@rust-highfive

This comment has been minimized.

Sign in to view
@Centril
Copy link
Contributor

Centril commented Oct 7, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Oct 7, 2019

📌 Commit 2dab187 has been approved by Centril

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 7, 2019
Centril added a commit to Centril/rust that referenced this pull request Oct 7, 2019
@Centril
Rollup merge of rust-lang#63948 - crlf0710:path_to_raw_dylib, r=Centril
0c96a12 
Add feature gate for raw_dylib.

This PR adds the feature gate for RFC 2627 (rust-lang#58713). It doesn't contain the actual functionality.
Add I'm not sure whether i did it correctly, since this is the first time i did this.

r? @Centril
@Centril Centril mentioned this pull request Oct 7, 2019
Merged
bors added a commit that referenced this pull request Oct 7, 2019
@bors
Auto merge of #65178 - Centril:rollup-ep1zztj, r=Centril
e3cb9ea 
Rollup of 4 pull requests

Successful merges:

 - #63948 (Add feature gate for raw_dylib.)
 - #65137 (remove event that causes panics in measureme tools)
 - #65164 (Add long error explanation for E0566)
 - #65173 (Update reference)

Failed merges:

r? @ghost
@bors bors merged commit 2dab187 into rust-lang:master Oct 7, 2019
@crlf0710 crlf0710 mentioned this pull request Oct 8, 2019
Open
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Centril Centril Centril left review comments

@nagisa nagisa nagisa left review comments

Assignees

@Centril Centril

Labels
F-raw_dylib `#![feature(raw_dylib)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@crlf0710 @rust-highfive @Centril @joshtriplett @retep998 @JohnCSimon @bors @nagisa