-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 11 pull requests #63540
Rollup of 11 pull requests #63540
Commits on Jul 30, 2019
-
Deduplicate some error messages
chansuke committedJul 30, 2019 Configuration menu - View commit details
-
Copy full SHA for a1df132 - Browse repository at this point
Copy the full SHA a1df132View commit details
Commits on Aug 8, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 43a2cbd - Browse repository at this point
Copy the full SHA 43a2cbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for a694782 - Browse repository at this point
Copy the full SHA a694782View commit details -
Configuration menu - View commit details
-
Copy full SHA for d9294a2 - Browse repository at this point
Copy the full SHA d9294a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for f395787 - Browse repository at this point
Copy the full SHA f395787View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5ce8f7a - Browse repository at this point
Copy the full SHA 5ce8f7aView commit details
Commits on Aug 10, 2019
-
Configuration menu - View commit details
-
Copy full SHA for 51ce121 - Browse repository at this point
Copy the full SHA 51ce121View commit details
Commits on Aug 12, 2019
-
ci: move mirrors to their standalone bucket
Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with CI toolchains. This is problematic for multiple reasons: - CI IAM credentials are allowed to both edit and delete those files. A malicious user gaining access to those credentials would be able to change our mirrored dependencies, possibly backdooring the compiler. - Contents of the rust-lang-ci2 bucket are disposable except for the mirrors' content. When we implement backups for S3 buckets we'd have to replicate just that part of the bucket, complicating the backup logic and increasing the chance of mistakes. A standalone bucket will be way easier to backup. This commit switches our CI to use the new rust-lang-ci-mirrors bucket.
Configuration menu - View commit details
-
Copy full SHA for eb832b2 - Browse repository at this point
Copy the full SHA eb832b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 91af5c2 - Browse repository at this point
Copy the full SHA 91af5c2View commit details -
Configuration menu - View commit details
-
Copy full SHA for fecf305 - Browse repository at this point
Copy the full SHA fecf305View commit details -
This fixes handling default configuration for the `crate_blacklist` RLS configuration. Technically this isn't needed, as the VS Code extension can be configured to accept a predefined blacklist that's equal to the default one but it's best that it also lands so that we don't need to work around that. cc rust-lang#63472
Configuration menu - View commit details
-
Copy full SHA for 5124f34 - Browse repository at this point
Copy the full SHA 5124f34View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34dcca2 - Browse repository at this point
Copy the full SHA 34dcca2View commit details -
typeck: Prohibit RPIT types that inherit lifetimes
This commit prohibits return position `impl Trait` types that "inherit lifetimes" from the parent scope. The intent is to forbid cases that are challenging until they can be addressed properly.
Configuration menu - View commit details
-
Copy full SHA for 861d1bb - Browse repository at this point
Copy the full SHA 861d1bbView commit details
Commits on Aug 13, 2019
-
Configuration menu - View commit details
-
Copy full SHA for e9b3a01 - Browse repository at this point
Copy the full SHA e9b3a01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 417f9ea - Browse repository at this point
Copy the full SHA 417f9eaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 8abaf9d - Browse repository at this point
Copy the full SHA 8abaf9dView commit details -
Disable --cfg bootstrap in libcore
This is needed to permit us building core_arch which is a submodule dep (so we can't snap it to the new beta compiler).
Configuration menu - View commit details
-
Copy full SHA for 5b21f31 - Browse repository at this point
Copy the full SHA 5b21f31View commit details -
Configuration menu - View commit details
-
Copy full SHA for 28d2279 - Browse repository at this point
Copy the full SHA 28d2279View commit details
Commits on Aug 14, 2019
-
Rollup merge of rust-lang#62760 - chansuke:dedupe-error-messages, r=z…
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
Configuration menu - View commit details
-
Copy full SHA for 2843ff9 - Browse repository at this point
Copy the full SHA 2843ff9View commit details -
Rollup merge of rust-lang#62849 - davidtwco:prohibit-inheriting-lifet…
…imes, r=nikomatsakis typeck: Prohibit RPIT types that inherit lifetimes Part of rust-lang#61949. This PR prohibits return position `impl Trait` types that "inherit lifetimes" from the parent scope. The intent is to forbid cases that are challenging until they can be addressed properly. cc @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for 36ad359 - Browse repository at this point
Copy the full SHA 36ad359View commit details -
Rollup merge of rust-lang#63383 - Centril:async-lifetime-elision-test…
…s, r=nikomatsakis `async fn` lifetime elision tests Add `async fn` version of the tests in rust-lang#61207 per the first checkbox in rust-lang#62121 (comment). Works towards resolving blockers in rust-lang#63209. r? @nikomatsakis cc @cramertj
Configuration menu - View commit details
-
Copy full SHA for e386c78 - Browse repository at this point
Copy the full SHA e386c78View commit details -
Rollup merge of rust-lang#63421 - clarfon:escape_default, r=dtolnay
Implement Clone, Display for ascii::EscapeDefault This will mimic the same behaviour as the `char` version; `Display`ing the iterator will give its string representation without advancing it.
Configuration menu - View commit details
-
Copy full SHA for 5fc6aea - Browse repository at this point
Copy the full SHA 5fc6aeaView commit details -
Rollup merge of rust-lang#63459 - eddyb:issue-63430, r=petrochenkov
syntax: account for CVarArgs being in the argument list. Fixes rust-lang#63430 by testing for `1` argument (the `CVarArgs` itself) instead of `0`. Note that the error has basically been impossible to trigger since the change that caused rust-lang#63430, so perhaps we need an audit of untested errors. Also, this check probably belongs in AST validation/HIR lowering, but I'd rather fix it in place for now. r? @petrochenkov cc @dlrobertson
Configuration menu - View commit details
-
Copy full SHA for 4d63853 - Browse repository at this point
Copy the full SHA 4d63853View commit details -
Rollup merge of rust-lang#63470 - Mark-Simulacrum:rustc-depdep, r=ale…
…xcrichton Utilize -Zbinary-dep-depinfo in rustbuild The last commit moves us over to using binary-dep-depinfo while the first two permit us to bootstrap from what will become future beta, to be released in the next week (it's the `cfg(bootstrap)` processing). We no longer utilize stamp-file mtimes at all inside rustbuild, and a future PR may be able to entirely eliminate them by eagerly copying to the appropriate sysroot. The only mtime-based dependency tracking left is for documentation because we lie to Cargo about the rustdoc binary, so Cargo does not track changes to the real binary, and codegen-backends because binary-dep-depinfo does not emit that information into the depfiles. Both of these are fixable in the longer term but this existing patch gives us the following benefits: * We no longer delete Cargo target directories manually within a stage. Cross-stage, changes to codegen backends will still clear out target directories. This means that incremental state persists across individual steps (e.g., rebuilding libstd does not clear out librustc incremental state). Fixes rust-lang#54712. * Dependency tracking across steps within a given stage is now fully precise. We will not clear out all codegen backend dependencies due to changes in librustc_driver, for example, only deleting the final librustc_codegen_llvm crate. Fixes rust-lang#54008, fixes rust-lang#50481. * We properly track codegen backends as a dependency (equivalent to rustc) across changes. Fixes rust-lang#53284, and fixes rust-lang#52719. * Cross-stage dependency tracking of crates is also much more accurate and reliable. Most likely fixes rust-lang#49979 (but no reproduction steps in that issue). Fixes rust-lang#59105. cc rust-lang#63012
Configuration menu - View commit details
-
Copy full SHA for b566b96 - Browse repository at this point
Copy the full SHA b566b96View commit details -
Rollup merge of rust-lang#63475 - iluuu1994:issue-62632, r=Centril
Bring back suggestion for splitting `<-` into `< -` Closes rust-lang#62632
Configuration menu - View commit details
-
Copy full SHA for 2781889 - Browse repository at this point
Copy the full SHA 2781889View commit details -
Rollup merge of rust-lang#63485 - pietroalbini:new-mirror-bucket, r=a…
…lexcrichton ci: move mirrors to their standalone bucket Currently mirrors are stored in the rust-lang-ci2 S3 bucket along with CI toolchains. This is problematic for multiple reasons: - CI IAM credentials are allowed to both edit and delete those files. A malicious user gaining access to those credentials would be able to change our mirrored dependencies, possibly compromising the compiler. - Contents of the rust-lang-ci2 bucket are disposable except for the mirrors' content. When we implement backups for S3 buckets we'd have to replicate just that part of the bucket, complicating the backup logic and increasing the chance of mistakes. A standalone bucket will be way easier to backup. This commit switches our CI to use the new rust-lang-ci-mirrors bucket. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for e50b943 - Browse repository at this point
Copy the full SHA e50b943View commit details -
Rollup merge of rust-lang#63488 - RalfJung:diagnostic-docs, r=zackmdavis
Configuration menu - View commit details
-
Copy full SHA for db759ce - Browse repository at this point
Copy the full SHA db759ceView commit details -
Rollup merge of rust-lang#63491 - Xanewok:update-rls, r=Mark-Simulacrum
Update RLS This fixes handling default configuration for the `crate_blacklist` RLS configuration. Technically this isn't needed, as the VS Code extension can be configured to accept a predefined blacklist that's equal to the default one but it's best that it also lands so that we don't need to work around that. Without this, manually passing a `null` value as the configuration unfortunately crashes the RLS. This is the last fix related to configuration. cc rust-lang#63472 r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for 27b095a - Browse repository at this point
Copy the full SHA 27b095aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0e13a05 - Browse repository at this point
Copy the full SHA 0e13a05View commit details