-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deduplicate error messages #62022
Labels
A-const-eval
Area: Constant evaluation (MIR interpretation)
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
Comments
oli-obk
added
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
A-const-eval
Area: Constant evaluation (MIR interpretation)
labels
Jun 21, 2019
I'd like to work on this issue. |
Great! It's all yours. |
@rustbot claim |
@chansuke Are you still working on this? If not I can pick it up :) |
Centril
added a commit
to Centril/rust
that referenced
this issue
Aug 13, 2019
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
Centril
added a commit
to Centril/rust
that referenced
this issue
Aug 13, 2019
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this issue
Aug 14, 2019
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
Centril
added a commit
to Centril/rust
that referenced
this issue
Aug 14, 2019
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
Centril
added a commit
to Centril/rust
that referenced
this issue
Aug 14, 2019
…ackmdavis Deduplicate error messages in `librsctc_mir` Deduplicated the error messages in `librustc_mir`. rust-lang#62022
This was closed in #62760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-const-eval
Area: Constant evaluation (MIR interpretation)
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
cc @RalfJung
rust/src/librustc_mir/const_eval.rs
Lines 557 to 568 in 3977cc2
and
rust/src/librustc_mir/interpret/intern.rs
Lines 293 to 305 in 3977cc2
could be deduplicated by creating a function in
const_eval.rs
and calling it from both sitesThis issue has been assigned to @chansuke via this comment.
The text was updated successfully, but these errors were encountered: