Windows 10 SDK is also required now. #61550
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
The Windows SDK was always required. |
But why the guide and the Book did not mention that? It just waste lots of peoples time. |
|
It's true that Rust has alwasy required this, but @JacobSun did you perhaps have Visual Studio but without the required components installed? If so perhaps the components could be listed here to be sure to mention that they're required? |
|
I had tried to install c++ build tools without vs, vs with c++ build tools, and finally vs with c++ build tools and windows 10 sdk. |
README.md
Outdated
| @@ -132,6 +132,8 @@ MSVC builds of Rust additionally require an installation of Visual Studio 2017 | |||
| (or later) so `rustc` can use its linker. The simplest way is to get the | |||
| [Visual Studio Build Tools] and check the “C++ build tools” workload. | |||
|
|
|||
| Windows 10 SDK is also required now. | |||
There was a problem hiding this comment.
We would certainly want to phrase this in the present, that is, not "now".
There was a problem hiding this comment.
The link is also changed. There isn't a c++ build tools.
README.md
Outdated
|
|
||
| [Visual Studio Build Tools]: https://visualstudio.microsoft.com/downloads/#build-tools-for-visual-studio-2019 | ||
| [Visual Studio]: https://visualstudio.microsoft.com/zh-hans/downloads/ |
There was a problem hiding this comment.
The old link is redirected to vs 2019, and there is not a standalone C++ build tools.
There was a problem hiding this comment.
https://visualstudio.microsoft.com/downloads/ is language neutral link.
There was a problem hiding this comment.
I shouldn't paste that url.
|
@bors: r+ |
|
📌 Commit 3d6070d has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
Windows 10 SDK is also required now.
Windows 10 SDK is also required now.
Windows 10 SDK is also required now.
Rollup of 11 pull requests Successful merges: - #61518 (Add loops to doc list of things not stable in const fn) - #61526 (move some tests into subfolders) - #61550 (Windows 10 SDK is also required now.) - #61606 (Remove some legacy proc macro flavors) - #61652 (Mention slice patterns in array) - #61686 (librustc_errors: Add some more documentation) - #61698 (typeck: Fix const generic in repeat param ICE.) - #61707 (Azure: retry failed awscli installs) - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone) - #61724 (core: use memcmp optimization for 128 bit integer slices) - #61726 (Use `for_each` in `Iterator::partition`) Failed merges: r? @ghost
Rollup of 11 pull requests Successful merges: - #61518 (Add loops to doc list of things not stable in const fn) - #61526 (move some tests into subfolders) - #61550 (Windows 10 SDK is also required now.) - #61606 (Remove some legacy proc macro flavors) - #61652 (Mention slice patterns in array) - #61686 (librustc_errors: Add some more documentation) - #61698 (typeck: Fix const generic in repeat param ICE.) - #61707 (Azure: retry failed awscli installs) - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone) - #61724 (core: use memcmp optimization for 128 bit integer slices) - #61726 (Use `for_each` in `Iterator::partition`) Failed merges: r? @ghost
No description provided.