Add loops to doc list of things not stable in const fn #61518

czipperz · 2019-06-04T14:20:31Z

rust-highfive · 2019-06-04T14:20:36Z

(rust_highfive has picked a reviewer for you, use r? to override)

rust-highfive · 2019-06-04T14:41:39Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:16259ba6:start=1559658097696605921,finish=1559658186654318424,duration=88957712503
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---

[00:04:54] travis_fold:start:tidy
travis_time:start:tidy
tidy check
[00:04:55] tidy error: /checkout/src/librustc_mir/transform/qualify_min_const_fn.rs:302: line longer than 100 chars
[00:04:55] tidy error: /checkout/src/test/ui/consts/single_variant_match_ice.rs:18: line longer than 100 chars
[00:04:59] some tidy checks failed
[00:04:59] 
[00:04:59] 
[00:04:59] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor" "--quiet"
[00:04:59] 
[00:04:59] 
[00:04:59] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
[00:04:59] Build completed unsuccessfully in 0:01:10
---
travis_time:end:14beffc8:start=1559658496971012938,finish=1559658496975710709,duration=4697771
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:007e587c
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:07e2be84
travis_time:start:07e2be84
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:1ba51308
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

zackmdavis

CI is complaining about line length.

tidy check
[00:04:55] tidy error: /checkout/src/librustc_mir/transform/qualify_min_const_fn.rs:302: line longer than 100 chars
[00:04:55] tidy error: /checkout/src/test/ui/consts/single_variant_match_ice.rs:18: line longer than 100 chars
[00:04:59] some tidy checks failed

zackmdavis · 2019-06-04T15:17:54Z

src/test/ui/consts/single_variant_match_ice.rs

@@ -15,7 +15,7 @@ impl Foo {
        use self::Foo::*;

        match *self {
-            Prob => 0x1, //~ ERROR `if`, `match`, `&&` and `||` are not stable in const fn
+            Prob => 0x1, //~ ERROR `if`, `match`, `while`, `for`, `loop`, `&&` and `||` are not stable in const fn


move expectation comment to the next line and use the //~^ notation get around tidy

zackmdavis · 2019-06-04T15:18:24Z

src/librustc_mir/transform/qualify_min_const_fn.rs

@@ -299,7 +299,7 @@ fn check_terminator(

        TerminatorKind::FalseEdges { .. } | TerminatorKind::SwitchInt { .. } => Err((
            span,
-            "`if`, `match`, `&&` and `||` are not stable in const fn".into(),
+            "`if`, `match`, `while`, `for`, `loop`, `&&` and `||` are not stable in const fn".into(),


use \ continuation to satisfy tidy?

czipperz · 2019-06-06T05:12:20Z

@zackmdavis Thanks for the feedback. Honestly I think this error message is too long. What do you think about trying to reduce the length? I'm trying to bikeshed some new messages. Maybe:

conditional expressions are not stable in const fn

Centril · 2019-06-10T01:00:32Z

@czipperz I think:

loops and conditional expressions are not stable in const fn

would do.

r? @Centril r=me with that

src/librustc_mir/transform/qualify_min_const_fn.rs

czipperz · 2019-06-10T19:46:36Z

@Centril done

Centril · 2019-06-11T12:11:29Z

@bors r+ rollup

bors · 2019-06-11T12:11:30Z

📌 Commit 8e7ade8 has been approved by Centril

…s, r=Centril Add loops to doc list of things not stable in const fn Closes rust-lang#61508

@ghost

Rollup of 11 pull requests Successful merges: - #61518 (Add loops to doc list of things not stable in const fn) - #61526 (move some tests into subfolders) - #61550 (Windows 10 SDK is also required now.) - #61606 (Remove some legacy proc macro flavors) - #61652 (Mention slice patterns in array) - #61686 (librustc_errors: Add some more documentation) - #61698 (typeck: Fix const generic in repeat param ICE.) - #61707 (Azure: retry failed awscli installs) - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone) - #61724 (core: use memcmp optimization for 128 bit integer slices) - #61726 (Use `for_each` in `Iterator::partition`) Failed merges: r? @ghost

@ghost

Rollup of 11 pull requests Successful merges: - #61518 (Add loops to doc list of things not stable in const fn) - #61526 (move some tests into subfolders) - #61550 (Windows 10 SDK is also required now.) - #61606 (Remove some legacy proc macro flavors) - #61652 (Mention slice patterns in array) - #61686 (librustc_errors: Add some more documentation) - #61698 (typeck: Fix const generic in repeat param ICE.) - #61707 (Azure: retry failed awscli installs) - #61715 (make sure make_ascii_lowercase actually leaves upper-case non-ASCII characters alone) - #61724 (core: use memcmp optimization for 128 bit integer slices) - #61726 (Use `for_each` in `Iterator::partition`) Failed merges: r? @ghost

rust-highfive assigned zackmdavis Jun 4, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 4, 2019

zackmdavis reviewed Jun 4, 2019

View reviewed changes

rust-highfive assigned Centril and unassigned zackmdavis Jun 10, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2019

czipperz force-pushed the const-fn-doc-disallow-loops branch from 6488a59 to 8ba8534 Compare June 10, 2019 01:29

Centril reviewed Jun 10, 2019

View reviewed changes

src/librustc_mir/transform/qualify_min_const_fn.rs Outdated Show resolved Hide resolved

Reword const fn conditional and loop error text

8e7ade8

czipperz force-pushed the const-fn-doc-disallow-loops branch from 8ba8534 to 8e7ade8 Compare June 10, 2019 02:02

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 11, 2019

Centril added a commit to Centril/rust that referenced this pull request Jun 11, 2019

Rollup merge of rust-lang#61518 - czipperz:const-fn-doc-disallow-loop…

17393b2

…s, r=Centril Add loops to doc list of things not stable in const fn Closes rust-lang#61508

Centril mentioned this pull request Jun 11, 2019

Rollup of 11 pull requests #61741

Merged

bors merged commit 8e7ade8 into rust-lang:master Jun 12, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add loops to doc list of things not stable in const fn #61518

Add loops to doc list of things not stable in const fn #61518

czipperz commented Jun 4, 2019

rust-highfive commented Jun 4, 2019

rust-highfive commented Jun 4, 2019

zackmdavis left a comment

zackmdavis Jun 4, 2019

zackmdavis Jun 4, 2019

czipperz commented Jun 6, 2019 •

edited

Loading

Centril commented Jun 10, 2019

czipperz commented Jun 10, 2019

Centril commented Jun 11, 2019

bors commented Jun 11, 2019

Add loops to doc list of things not stable in const fn #61518

Add loops to doc list of things not stable in const fn #61518

Conversation

czipperz commented Jun 4, 2019

rust-highfive commented Jun 4, 2019

rust-highfive commented Jun 4, 2019

zackmdavis left a comment

Choose a reason for hiding this comment

zackmdavis Jun 4, 2019

Choose a reason for hiding this comment

zackmdavis Jun 4, 2019

Choose a reason for hiding this comment

czipperz commented Jun 6, 2019 • edited Loading

Centril commented Jun 10, 2019

czipperz commented Jun 10, 2019

Centril commented Jun 11, 2019

bors commented Jun 11, 2019

czipperz commented Jun 6, 2019 •

edited

Loading