Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaybeUninit: add read_initialized, add examples #58660

Merged
merged 15 commits into from
Mar 9, 2019

Conversation

RalfJung
Copy link
Member

This adds a new read_initialized method, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.

@rust-highfive
Copy link
Collaborator

r? @aidanhs

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 22, 2019
@RalfJung RalfJung force-pushed the maybe-uninit branch 2 times, most recently from b136922 to 48bba2c Compare February 22, 2019 22:01
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:26681e3c:start=1550876296723837634,finish=1550876297696067905,duration=972230271
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
Setting environment variables from .travis.yml
$ export IMAGE=x86_64-gnu-llvm-6.0
---
    97% |███████████████████████████████▍| 532kB 58.6MB/s eta 0:00:01
    99% |████████████████████████████████| 542kB 56.1MB/s eta 0:00:01
    100% |████████████████████████████████| 552kB 26.4MB/s 
Collecting botocore==1.12.101 (from awscli)
  Downloading https://files.pythonhosted.org/packages/d2/c1/bba75ff036a9363d32f597cddd0fbb6b6166a51f896631c4f57e56aacf65/botocore-1.12.101-py2.py3-none-any.whl (5.3MB)
    0% |▏                               | 20kB 29.7MB/s eta 0:00:01
    0% |▏                               | 30kB 34.7MB/s eta 0:00:01
    0% |▎                               | 40kB 38.2MB/s eta 0:00:01
    0% |▎                               | 51kB 41.5MB/s eta 0:00:01
---
[00:56:04]  Documenting core v0.0.0 (/checkout/src/libcore)
[00:56:21] warning: `[into_initialized]` cannot be resolved, ignoring it...
[00:56:21]     --> src/libcore/mem.rs:1326:46
[00:56:21]      |
[00:56:21] 1326 |     /// calling `read_initialized` and then [`into_initialized`]), it is your responsibility
[00:56:21]      |
[00:56:21] note: lint level defined here
[00:56:21]     --> src/libcore/lib.rs:63:9
[00:56:21]      |
---
[00:56:33]     Checking rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[00:56:33]     Checking rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:56:33]     Checking rustc_asan v0.0.0 (/checkout/src/librustc_asan)
[00:56:33]  Documenting std v0.0.0 (/checkout/src/libstd)
[00:56:40] error: `[into_initialized]` cannot be resolved, ignoring it...
[00:56:40]      |
[00:56:40]      |
[00:56:40] 1326 |     /// calling `read_initialized` and then [`into_initialized`]), it is your responsibility
[00:56:40]      |
[00:56:40] note: lint level defined here
[00:56:40]     --> src/libstd/lib.rs:209:9
[00:56:40]      |
[00:56:40]      |
[00:56:40] 209  | #![deny(intra_doc_link_resolution_failure)]
[00:56:40]      |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[00:56:40]      = help: to escape `[` and `]` characters, just add '\' before them like `\[` or `\]`
[00:56:40] 
[00:56:40] error: Could not document `std`.
[00:56:40] 
[00:56:40] Caused by:
[00:56:40]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustdoc --crate-name std src/libstd/lib.rs --color always --target x86_64-unknown-linux-gnu -o /checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/doc --cfg 'feature="backtrace"' --cfg 'feature="backtrace-sys"' --cfg 'feature="compiler_builtins"' --cfg 'feature="compiler_builtins_c"' --cfg 'feature="default"' --cfg 'feature="panic-unwind"' --cfg 'feature="panic_unwind"' --cfg 'feature="std_detect_dlsym_getauxval"' --cfg 'feature="std_detect_file_io"' --markdown-css rust.css --markdown-no-toc --generate-redirect-pages --index-page /checkout/src/doc/index.md -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/release/deps --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liballoc-9e6c0311b71511c6.rmeta --extern backtrace_sys=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libbacktrace_sys-f13b165ed9b4dd57.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcompiler_builtins-d54fe968dea87029.rmeta --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libcore-84e5b9599b1b7754.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/liblibc-a69fda92b07aedd5.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_abort-349a3e5cce9f18ee.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libpanic_unwind-d7c48504ff1056b6.rmeta --extern rustc_demangle=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_demangle-20814bca47e9a554.rmeta --extern rustc_asan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_asan-8bc4c4bf1d4ec8f0.rmeta --extern rustc_lsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_lsan-0814373332ff833c.rmeta --extern rustc_msan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_msan-655667bc8a1522d0.rmeta --extern rustc_tsan=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/librustc_tsan-5756fbda854daecf.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage1-std/x86_64-unknown-linux-gnu/release/deps/libunwind-5e31c590860d0940.rmeta` (exit code: 1)
[00:56:40] 
[00:56:40] 
[00:56:40] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "rustdoc" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-Z" "unstable-options" "-p" "std" "--" "--markdown-css" "rust.css" "--markdown-no-toc" "--generate-redirect-pages" "--index-page" "/checkout/src/doc/index.md"
[00:56:40] 
[00:56:40] 
[00:56:40] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap doc
[00:56:40] Build completed unsuccessfully in 0:06:07
---
travis_time:end:05402bb0:start=1550879710959348000,finish=1550879710965134673,duration=5786673
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:100dca54
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0bcc43f4
travis_time:start:0bcc43f4
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:031f8dfe
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@RalfJung
Copy link
Member Author

I've been thinking maybe it should be called get_initialized instead of read_initialized. It's kind of a complement to set.

OTOH, read I think better invokes the idea that this is a lot like ptr::read -- it makes a copy. Maybe set should be renamed to write? It also has the parallel that it doesn't invoke the destructor on the overwritten balue.

@Amanieu
Copy link
Member

Amanieu commented Feb 23, 2019

I think get_initialized is fine. It mirrors Cell where get also performs a copy.

I'm really happy about the Copy change, I tried to make [MaybeUninit<u8>; 4] but couldn't create the array because MaybeUninit isn't Copy.

@scottmcm
Copy link
Member

I always thought of these as read and write since the rules are so similar. (ptr::reading something twice that's needs_drop -- and then letting it drop -- is just as bad as doing so from a MaybeUninit.)

To me, get sounds like once it's initialized, you can get as much as you want -- like you can in Cell.

@RalfJung
Copy link
Member Author

Yeah, my current inclination is to instead rename set to write, to complete the analogy. writeing twice something that's needs_drop means we skipped a destructor.

@RalfJung
Copy link
Member Author

Well, let's do the bikeshedding later and add this as read_uninitialized for now, I'd say.

@Dylan-DPC-zz
Copy link

r? @Centril

@rust-highfive rust-highfive assigned Centril and unassigned aidanhs Mar 4, 2019
src/libcore/mem.rs Outdated Show resolved Hide resolved
src/libcore/mem.rs Outdated Show resolved Hide resolved
// FIXME before stabilizing, explain how to initialize a struct field-by-field.
#[allow(missing_debug_implementations)]
#[unstable(feature = "maybe_uninit", issue = "53491")]
// NOTE after stabilizing `MaybeUninit` proceed to deprecate `mem::{uninitialized,zeroed}`
#[derive(Copy)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remind me... what was the reason we didn't do this before?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there was one.

src/libcore/mem.rs Outdated Show resolved Hide resolved
@Centril
Copy link
Contributor

Centril commented Mar 6, 2019

r=me with green CI :)

src/libcore/mem.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member Author

RalfJung commented Mar 6, 2019

@bors r=Centril

@bors
Copy link
Contributor

bors commented Mar 6, 2019

📌 Commit cefe9b0 has been approved by Centril

@bors
Copy link
Contributor

bors commented Mar 6, 2019

🌲 The tree is currently closed for pull requests below priority 50, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 6, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019
MaybeUninit: add read_initialized, add examples

This adds a new `read_initialized` method, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.
Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019
MaybeUninit: add read_initialized, add examples

This adds a new `read_initialized` method, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.
Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019
MaybeUninit: add read_initialized, add examples

This adds a new `read_initialized` method, similar to suggestions by @Amanieu and @shepmaster. I also added examples to this and other methods.
bors added a commit that referenced this pull request Mar 9, 2019
Rollup of 13 pull requests

Successful merges:

 - #58518 (Use early unwraps instead of bubbling up errors just to unwrap in the end)
 - #58626 (rustdoc: add option to calculate "documentation coverage")
 - #58629 (rust-lldb: fix crash when printing empty string)
 - #58660 (MaybeUninit: add read_initialized, add examples)
 - #58670 (fixes #52482)
 - #58676 (look for python2 symlinks before bootstrap python)
 - #58679 (Refactor passes and pass execution to be more parallel)
 - #58750 (Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const)
 - #58762 (Mention `unwind(aborts)` in diagnostics for `#[unwind]`)
 - #58924 (Add as_slice() to slice::IterMut and vec::Drain)
 - #58990 (Actually publish miri in the manifest)
 - #59018 (std: Delete a by-definition spuriously failing test)
 - #59045 (Expose new_sub_parser_from_file)

Failed merges:

r? @ghost
@bors bors merged commit cefe9b0 into rust-lang:master Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants