Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use early unwraps instead of bubbling up errors just to unwrap in the end #58518

Merged
merged 1 commit into from
Mar 9, 2019

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Feb 16, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Feb 16, 2019
@RalfJung
Copy link
Member

Looks reasonable, and Travis agrees.

@bors r+

@bors
Copy link
Contributor

bors commented Feb 16, 2019

📌 Commit 9cdfff62f45cc5d4819060cf252a6a6375be8f0e has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 16, 2019
@bors
Copy link
Contributor

bors commented Feb 24, 2019

☔ The latest upstream changes (presumably #58691) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2019
@oli-obk
Copy link
Contributor Author

oli-obk commented Mar 5, 2019

@bors r=RalfJung

@bors
Copy link
Contributor

bors commented Mar 5, 2019

📌 Commit 5c0615b has been approved by RalfJung

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 5, 2019
Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019
…r=RalfJung

Use early unwraps instead of bubbling up errors just to unwrap in the end

r? @RalfJung
Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019
…r=RalfJung

Use early unwraps instead of bubbling up errors just to unwrap in the end

r? @RalfJung
Centril added a commit to Centril/rust that referenced this pull request Mar 9, 2019
…r=RalfJung

Use early unwraps instead of bubbling up errors just to unwrap in the end

r? @RalfJung
bors added a commit that referenced this pull request Mar 9, 2019
Rollup of 13 pull requests

Successful merges:

 - #58518 (Use early unwraps instead of bubbling up errors just to unwrap in the end)
 - #58626 (rustdoc: add option to calculate "documentation coverage")
 - #58629 (rust-lldb: fix crash when printing empty string)
 - #58660 (MaybeUninit: add read_initialized, add examples)
 - #58670 (fixes #52482)
 - #58676 (look for python2 symlinks before bootstrap python)
 - #58679 (Refactor passes and pass execution to be more parallel)
 - #58750 (Make `Unique::as_ptr`, `NonNull::dangling` and `NonNull::cast` const)
 - #58762 (Mention `unwind(aborts)` in diagnostics for `#[unwind]`)
 - #58924 (Add as_slice() to slice::IterMut and vec::Drain)
 - #58990 (Actually publish miri in the manifest)
 - #59018 (std: Delete a by-definition spuriously failing test)
 - #59045 (Expose new_sub_parser_from_file)

Failed merges:

r? @ghost
@bors bors merged commit 5c0615b into rust-lang:master Mar 9, 2019
@oli-obk oli-obk deleted the unreachable_result_errors branch March 16, 2021 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants