Rollup of 16 pull requests #58361
Merged
Rollup of 16 pull requests #58361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is easier and it should be also faster, because `to_ne_bytes` just calls `mem::transmute`.
This is not really significant, accept or reject as you wish. I just want to make sure I understand how the PR process works and I'm doing it right before doing a bigger one for rust-lang#33417.
Update reference of rlibc crate to compiler-builtins crate None
…r=scottmcm Use `to_ne_bytes` for converting IPv4Addr to octets It is easier and it should be also faster, because [`to_ne_bytes`](https://doc.rust-lang.org/std/primitive.u32.html#method.to_ne_bytes) just calls `mem::transmute`.
Tiny expansion to docs for `core::convert`. This is not really significant, accept or reject as you wish. I just want to make sure I understand how the PR process works and that I'm doing it right before doing a bigger one for rust-lang#33417.
Add Cargo.lock automatically adding message If I execute `cargo +nightly fix`, this change always occurs; cc rust-lang#58099 r? @Centril
rustdoc: display sugared return types for async functions Fixes rust-lang#58027.
…Manishearth Add trait alias support in rustdoc Fixes rust-lang#57595. r? @QuietMisdreavus
Add #[must_use] message to Fn* traits This PR adds `#[must_use]` message to `Fn*` traits. Related: rust-lang#57549 r? @estebank
std::sys::unix::stdio: explain why we do into_raw I was quite puzzled why someone would call `into_raw` and then ignore the result.
…isdreavus Cleanup JS a bit r? @QuietMisdreavus
Some writing improvement, conciseness of intro Made unstable-features doc more concise in the introduction paragraph
miri: give non-generic functions a stable address This makes Miri correctly handle format string parameters despite rust-lang#58320. Matching Miri PR: rust-lang/miri#626 r? @oli-obk
…r=oli-obk operand-to-place copies should never be overlapping This seems to just work (verified with the Miri test suite). r? @oli-obk
When there are multiple filenames, print what got interpreted as filenames I have written code that crafts command lines for rustc, and when I get "multiple input filenames provided" it can be quite hard to figure out where in this long list of arguments the mistake is hiding. Probably I passed an argument to a flag that does not expect an argument, but which flag would that be? This changes the error message to print the first two filenames, to make it easier to debug what is going on.
rpath computation: explain why we pop() I was quite confused by this code until I got a debug log of what is going on.
Fix failing tidy (line endings on Windows) Updates to `embedded-book` including rust-embedded/book#127.
miri value visitor: use `?` in macro
|
@bors: r+ p=16 |
|
📌 Commit d792cef has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Feb 10, 2019
Rollup of 16 pull requests Successful merges: - #57259 (Update reference of rlibc crate to compiler-builtins crate) - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets) - #57926 (Tiny expansion to docs for `core::convert`.) - #58157 (Add Cargo.lock automatically adding message) - #58203 (rustdoc: display sugared return types for async functions) - #58243 (Add trait alias support in rustdoc) - #58262 (Add #[must_use] message to Fn* traits) - #58295 (std::sys::unix::stdio: explain why we do into_raw) - #58297 (Cleanup JS a bit) - #58317 (Some writing improvement, conciseness of intro) - #58324 (miri: give non-generic functions a stable address) - #58332 (operand-to-place copies should never be overlapping) - #58345 (When there are multiple filenames, print what got interpreted as filenames) - #58346 (rpath computation: explain why we pop()) - #58350 (Fix failing tidy (line endings on Windows)) - #58352 (miri value visitor: use `?` in macro) Failed merges: r? @ghost
|
☀️ Test successful - checks-travis, status-appveyor |
This was referenced Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
to_ne_bytesfor converting IPv4Addr to octets #57740 (Useto_ne_bytesfor converting IPv4Addr to octets)core::convert. #57926 (Tiny expansion to docs forcore::convert.)?in macro #58352 (miri value visitor: use?in macro)Failed merges:
r? @ghost