rustdoc: display sugared return types for async functions #58203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euclio
changed the title
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
src/test/rustdoc/async-fn.rs
Outdated
|
|
||
| #![feature(async_await, futures_api)] | ||
|
|
||
| // @has async_fn/fn.foo.html '//pre[@class="rust fn"]' 'pub async fn foo() -> Option<S>' | ||
| pub async fn foo() -> Option<S> { |
There was a problem hiding this comment.
I thought that S was a type parameter because the name was only one letter. Can you make it at least two letters so people won't struggle on it in the future (haha) please?
|
Please fix my comment and then we're good to go! |
|
@GuillaumeGomez Fixed, also added a test case that uses |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 4deb595 has been approved by |
bors
added
S-waiting-on-bors
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 8, 2019
rustdoc: display sugared return types for async functions Fixes rust-lang#58027.
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Feb 10, 2019
rustdoc: display sugared return types for async functions Fixes rust-lang#58027.
Mark-Simulacrum
added a commit
to Mark-Simulacrum/rust
that referenced
this pull request
Feb 10, 2019
rustdoc: display sugared return types for async functions Fixes rust-lang#58027.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 10, 2019
rustdoc: display sugared return types for async functions Fixes rust-lang#58027.
bors
added a commit
that referenced
this pull request
Feb 10, 2019
Rollup of 16 pull requests Successful merges: - #57259 (Update reference of rlibc crate to compiler-builtins crate) - #57740 (Use `to_ne_bytes` for converting IPv4Addr to octets) - #57926 (Tiny expansion to docs for `core::convert`.) - #58157 (Add Cargo.lock automatically adding message) - #58203 (rustdoc: display sugared return types for async functions) - #58243 (Add trait alias support in rustdoc) - #58262 (Add #[must_use] message to Fn* traits) - #58295 (std::sys::unix::stdio: explain why we do into_raw) - #58297 (Cleanup JS a bit) - #58317 (Some writing improvement, conciseness of intro) - #58324 (miri: give non-generic functions a stable address) - #58332 (operand-to-place copies should never be overlapping) - #58345 (When there are multiple filenames, print what got interpreted as filenames) - #58346 (rpath computation: explain why we pop()) - #58350 (Fix failing tidy (line endings on Windows)) - #58352 (miri value visitor: use `?` in macro) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58027.