Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 11 pull requests #55433

Merged
merged 27 commits into from
Oct 28, 2018
Merged

Rollup of 11 pull requests #55433

merged 27 commits into from
Oct 28, 2018

Commits on Oct 17, 2018

  1. Implement FromStr for PathBuf

    Initially landed in rust-lang#48292
    and reverted in rust-lang#50401.
    This time, use `std::string::ParseError` as suggested in
    rust-lang#44431 (comment)
    SimonSapin committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    a0df420 View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2018

  1. Add MaybeUninit::new

    Sometimes it *is* initialized!
    SimonSapin committed Oct 21, 2018
    Configuration menu
    Copy the full SHA
    ac18635 View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2018

  1. Configuration menu
    Copy the full SHA
    412ad9b View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5b84550 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2018

  1. Don't rerun Mir passes when inlining

    When inlining a function using the Mir inliner, we shouldn't rerun the
    various Mir passes on it because the Mir has already been lowered and
    that wil break various early Mir passes.
    
    The issue in rust-lang#50411 is that we've inlined a function with promotions
    whose Mir has already been lowered. The promotions are then copied into
    the local function and we begin to run passes on their lowered Mir
    which causes the ICE.
    
    Fixes rust-lang#50411
    nikomatsakis authored and wesleywiser committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    37e1d29 View commit details
    Browse the repository at this point in the history
  2. Remove the suite_index parameter of the run_passes!() macro

    This can be obtained via the `$mir_phase` value.
    wesleywiser committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    895a4b2 View commit details
    Browse the repository at this point in the history
  3. Replace the run_passes! macro with a regular function

    As suggested in the feedback for rust-lang#55244.
    
    When I replaced the macro with a function, rustc started complaining
    that there were two unused functions so I also removed those.
    wesleywiser committed Oct 23, 2018
    Configuration menu
    Copy the full SHA
    c535147 View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2018

  1. Fix CR feedback

    wesleywiser committed Oct 25, 2018
    Configuration menu
    Copy the full SHA
    4655866 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2018

  1. Configuration menu
    Copy the full SHA
    c674802 View commit details
    Browse the repository at this point in the history
  2. Impl items have generics

    oli-obk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    b9bd2a6 View commit details
    Browse the repository at this point in the history
  3. Update tests

    oli-obk committed Oct 26, 2018
    Configuration menu
    Copy the full SHA
    5a48f20 View commit details
    Browse the repository at this point in the history

Commits on Oct 27, 2018

  1. Update string.rs

    remove unused variable i in example String::with_capacity()
    rick68 authored Oct 27, 2018
    Configuration menu
    Copy the full SHA
    4cb611f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    c04893a View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    2fd378b View commit details
    Browse the repository at this point in the history

Commits on Oct 28, 2018

  1. Add note linking to Rust 2018 path semantics docs.

    This commit extends existing path suggestions to link to documentation
    on the changed semantics of `use` in Rust 2018.
    davidtwco committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    0d06b8c View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    0757c0f View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#55148 - SimonSapin:path-fromstr, r=oli-obk

    Implement FromStr for PathBuf
    
    Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)
    kennytm authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    b9763de View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#55191 - GuillaumeGomez:fix-sub-variant, r=Q…

    …uietMisdreavus
    
    Fix sub-variant doc display
    
    Fixes rust-lang#54758.
    
    <img width="1440" alt="screen shot 2018-10-19 at 01 34 11" src="https://user-images.githubusercontent.com/3050060/47189939-43481d00-d33f-11e8-868f-cf479fc79e62.png">
    
    r? @QuietMisdreavus
    kennytm authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    883b819 View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#55244 - wesleywiser:issue-50411, r=nikomats…

    …akis
    
    Don't rerun MIR passes when inlining
    
    Fixes rust-lang#50411
    
    r? @nikomatsakis
    
    I updated your commit message with additional details. Let me know if any of that is incorrect. I also added the appropriate `compile-flags` directive to the test.
    
    Thanks for you help on this!
    
    cc @RalfJung related to your PR rust-lang#55086
    kennytm authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    409382e View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#55252 - SimonSapin:maybeuninit-new, r=bluss

    Add MaybeUninit::new
    
    Sometimes it *is* initialized!
    kennytm authored Oct 28, 2018
    Configuration menu
    Copy the full SHA
    a79b912 View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#55389 - meven:master, r=shepmaster

    Remove unnecessary mut in iterator.find_map documentation example, R…
    
    Relates to rust-lang#49098
    
    Removes a mut that could induce newcomers to put a mut in their code that the compiler would comply about.
    
    https://github.com/rust-lang/rust/pull/49098/files#r227422388
    kennytm committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    316a443 View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#55406 - rick68:patch-16, r=varkor

    Update string.rs
    
    remove unused variable i in example String::with_capacity()
    kennytm committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    7a95c28 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#55412 - oli-obk:min_const_fn_ice, r=estebank

    Fix an ICE in the min_const_fn analysis
    
    fixes rust-lang#55395
    
    cc @Centril
    kennytm committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    b565e5d View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#55421 - CAD97:patch-1, r=kennytm

    Add ManuallyDrop::take
    
    Tracking issue: rust-lang#55422
    
    Proposed in this form in https://internals.rust-lang.org/t/mini-rfc-manuallydrop-take/8679,
    see that thread for some history.
    
    A small convenience wrapper for `ManuallyDrop` that makes a pattern (taking ownership of the contained data in drop) more obvious.
    kennytm committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    360f32a View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#55185 - davidtwco:issue-55130, r=nikomatsakis

    path suggestions in Rust 2018 should point out the change in semantics
    
    Fixes rust-lang#55130.
    
    This commit extends existing path suggestions to link to documentation
    on the changed semantics of `use` in Rust 2018.
    kennytm committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    aaa20c6 View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#55257 - mjbshaw:static, r=oli-obk

    Allow extern statics with an extern type
    
    Fixes rust-lang#55239
    kennytm committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    abf7243 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#55199 - oli-obk:instance_printing, r=davidtwco

    Impl items have generics
    kennytm committed Oct 28, 2018
    Configuration menu
    Copy the full SHA
    db4e77c View commit details
    Browse the repository at this point in the history