Rollup of 11 pull requests #55433

kennytm · 2018-10-28T08:38:56Z

Successful merges:

Implement FromStr for PathBuf #55148 (Implement FromStr for PathBuf)
path suggestions in Rust 2018 should point out the change in semantics #55185 (path suggestions in Rust 2018 should point out the change in semantics)
Fix sub-variant doc display #55191 (Fix sub-variant doc display)
Impl items have generics #55199 (Impl items have generics)
Don't rerun MIR passes when inlining #55244 (Don't rerun MIR passes when inlining)
Add MaybeUninit::new #55252 (Add MaybeUninit::new)
Allow extern statics with an extern type #55257 (Allow extern statics with an extern type)
Remove unnecessary mut in iterator.find_map documentation example, R… #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…)
Update string.rs #55406 (Update string.rs)
Fix an ICE in the min_const_fn analysis #55412 (Fix an ICE in the min_const_fn analysis)
Add ManuallyDrop::take #55421 (Add ManuallyDrop::take)

Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)

Sometimes it *is* initialized!

Fixes rust-lang#55239

When inlining a function using the Mir inliner, we shouldn't rerun the various Mir passes on it because the Mir has already been lowered and that wil break various early Mir passes. The issue in rust-lang#50411 is that we've inlined a function with promotions whose Mir has already been lowered. The promotions are then copied into the local function and we begin to run passes on their lowered Mir which causes the ICE. Fixes rust-lang#50411

This can be obtained via the `$mir_phase` value.

As suggested in the feedback for rust-lang#55244. When I replaced the macro with a function, rustc started complaining that there were two unused functions so I also removed those.

…lates to rust-lang#49098

remove unused variable i in example String::with_capacity()

This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018.

https://internals.rust-lang.org/t/mini-rfc-manuallydrop-take/8679

Implement FromStr for PathBuf Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)

@QuietMisdreavus

…uietMisdreavus Fix sub-variant doc display Fixes rust-lang#54758. <img width="1440" alt="screen shot 2018-10-19 at 01 34 11" src="https://user-images.githubusercontent.com/3050060/47189939-43481d00-d33f-11e8-868f-cf479fc79e62.png"> r? @QuietMisdreavus

@nikomatsakis

…akis Don't rerun MIR passes when inlining Fixes rust-lang#50411 r? @nikomatsakis I updated your commit message with additional details. Let me know if any of that is incorrect. I also added the appropriate `compile-flags` directive to the test. Thanks for you help on this! cc @RalfJung related to your PR rust-lang#55086

Add MaybeUninit::new Sometimes it *is* initialized!

kennytm · 2018-10-28T08:39:10Z

@bors r+ p=9

bors · 2018-10-28T08:39:10Z

📌 Commit bfe15b59c0c20173493bbaf82b2756358b679b6e has been approved by kennytm

kennytm · 2018-10-28T08:51:33Z

@bors r+

Removed #55262 (high risk, maybe causing failure of #55425 (comment))

bors · 2018-10-28T08:51:34Z

📌 Commit a6d97281a5481db835e101db3dc93bd5dff13469 has been approved by kennytm

bors · 2018-10-28T10:59:29Z

⌛ Testing commit a6d97281a5481db835e101db3dc93bd5dff13469 with merge 8a21b8e099d1daf8afd39fcbd7106f4ef4fabaf4...

kennytm · 2018-10-28T11:16:32Z

@bors treeclosed=1

Travis jobs are not starting due to https://www.traviscistatus.com/incidents/7k1r5btfg45m

bjorn3 · 2018-10-28T12:20:43Z

Travis incident is resolved.

bors · 2018-10-28T12:35:16Z

💔 Test failed - status-appveyor

Remove unnecessary mut in iterator.find_map documentation example, R… Relates to rust-lang#49098 Removes a mut that could induce newcomers to put a mut in their code that the compiler would comply about. https://github.com/rust-lang/rust/pull/49098/files#r227422388

Update string.rs remove unused variable i in example String::with_capacity()

@Centril

Fix an ICE in the min_const_fn analysis fixes rust-lang#55395 cc @Centril

Add ManuallyDrop::take Tracking issue: rust-lang#55422 Proposed in this form in https://internals.rust-lang.org/t/mini-rfc-manuallydrop-take/8679, see that thread for some history. A small convenience wrapper for `ManuallyDrop` that makes a pattern (taking ownership of the contained data in drop) more obvious.

path suggestions in Rust 2018 should point out the change in semantics Fixes rust-lang#55130. This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018.

Allow extern statics with an extern type Fixes rust-lang#55239

Impl items have generics

kennytm · 2018-10-28T13:39:57Z

@bors r+ treeclosed-

Removed #55304 (causing the error above)
Added #55421, #55185, #55257, #55199.

bors · 2018-10-28T13:39:58Z

📌 Commit db4e77c has been approved by kennytm

bors · 2018-10-28T16:00:07Z

⌛ Testing commit db4e77c with merge d492c67...

Rollup of 11 pull requests Successful merges: - #55148 (Implement FromStr for PathBuf) - #55185 (path suggestions in Rust 2018 should point out the change in semantics) - #55191 (Fix sub-variant doc display) - #55199 (Impl items have generics) - #55244 (Don't rerun MIR passes when inlining) - #55252 (Add MaybeUninit::new) - #55257 (Allow extern statics with an extern type) - #55389 (Remove unnecessary mut in iterator.find_map documentation example, R…) - #55406 (Update string.rs) - #55412 (Fix an ICE in the min_const_fn analysis) - #55421 (Add ManuallyDrop::take)

bors · 2018-10-28T18:49:41Z

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing d492c67 to master...

SimonSapin and others added 20 commits October 17, 2018 15:54

Implement FromStr for PathBuf

a0df420

Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)

Add MaybeUninit::new

ac18635

Sometimes it *is* initialized!

Allow extern statics with an extern type

412ad9b

Fixes rust-lang#55239

Keep an obligation for both sized and unsized types

5b84550

Remove the suite_index parameter of the run_passes!() macro

895a4b2

This can be obtained via the `$mir_phase` value.

Replace the run_passes! macro with a regular function

c535147

As suggested in the feedback for rust-lang#55244. When I replaced the macro with a function, rustc started complaining that there were two unused functions so I also removed those.

Fix CR feedback

4655866

Remove unnecessary mut in iterator.find_map documentation example, Re…

c674802

…lates to rust-lang#49098

Impl items have generics

b9bd2a6

Update tests

5a48f20

Update string.rs

4cb611f

remove unused variable i in example String::with_capacity()

Fix an ICE in the min_const_fn analysis

c04893a

Fix sub-variant doc display

2fd378b

Add note linking to Rust 2018 path semantics docs.

0d06b8c

This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018.

Add ManuallyDrop::take

0757c0f

https://internals.rust-lang.org/t/mini-rfc-manuallydrop-take/8679

Rollup merge of rust-lang#55148 - SimonSapin:path-fromstr, r=oli-obk

b9763de

Implement FromStr for PathBuf Initially landed in rust-lang#48292 and reverted in rust-lang#50401. This time, use `std::string::ParseError` as suggested in rust-lang#44431 (comment)

Rollup merge of rust-lang#55252 - SimonSapin:maybeuninit-new, r=bluss

a79b912

Add MaybeUninit::new Sometimes it *is* initialized!

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 28, 2018

kennytm force-pushed the rollup branch from bfe15b5 to a6d9728 Compare October 28, 2018 08:51

kennytm changed the title ~~Rollup of 9 pull requests~~ Rollup of 8 pull requests Oct 28, 2018

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Oct 28, 2018

kennytm added 3 commits October 28, 2018 21:23

Rollup merge of rust-lang#55406 - rick68:patch-16, r=varkor

7a95c28

Update string.rs remove unused variable i in example String::with_capacity()

Rollup merge of rust-lang#55412 - oli-obk:min_const_fn_ice, r=estebank

b565e5d

Fix an ICE in the min_const_fn analysis fixes rust-lang#55395 cc @Centril

kennytm mentioned this pull request Oct 28, 2018

ci: Move global credentials to web configuration #55304

Merged

kennytm added 4 commits October 28, 2018 21:32

Rollup merge of rust-lang#55185 - davidtwco:issue-55130, r=nikomatsakis

aaa20c6

path suggestions in Rust 2018 should point out the change in semantics Fixes rust-lang#55130. This commit extends existing path suggestions to link to documentation on the changed semantics of `use` in Rust 2018.

Rollup merge of rust-lang#55257 - mjbshaw:static, r=oli-obk

abf7243

Allow extern statics with an extern type Fixes rust-lang#55239

Rollup merge of rust-lang#55199 - oli-obk:instance_printing, r=davidtwco

db4e77c

Impl items have generics

kennytm force-pushed the rollup branch from a6d9728 to db4e77c Compare October 28, 2018 13:39

kennytm changed the title ~~Rollup of 8 pull requests~~ Rollup of 11 pull requests Oct 28, 2018

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 28, 2018

bors merged commit db4e77c into rust-lang:master Oct 28, 2018

Centril added the rollup A PR which is a rollup label Oct 2, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 11 pull requests #55433

Rollup of 11 pull requests #55433

kennytm commented Oct 28, 2018 •

edited

Loading

kennytm commented Oct 28, 2018

bors commented Oct 28, 2018

kennytm commented Oct 28, 2018

bors commented Oct 28, 2018

bors commented Oct 28, 2018

kennytm commented Oct 28, 2018

bjorn3 commented Oct 28, 2018

bors commented Oct 28, 2018

kennytm commented Oct 28, 2018

bors commented Oct 28, 2018

bors commented Oct 28, 2018

bors commented Oct 28, 2018

Rollup of 11 pull requests #55433

Rollup of 11 pull requests #55433

Conversation

kennytm commented Oct 28, 2018 • edited Loading

kennytm commented Oct 28, 2018

bors commented Oct 28, 2018

kennytm commented Oct 28, 2018

bors commented Oct 28, 2018

bors commented Oct 28, 2018

kennytm commented Oct 28, 2018

bjorn3 commented Oct 28, 2018

bors commented Oct 28, 2018

kennytm commented Oct 28, 2018

bors commented Oct 28, 2018

bors commented Oct 28, 2018

bors commented Oct 28, 2018

kennytm commented Oct 28, 2018 •

edited

Loading