-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated RELEASES for 1.28.0 #51722
Merged
Merged
Updated RELEASES for 1.28.0 #51722
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,144 @@ | ||
Version 1.28.0 (2018-08-02) | ||
=========================== | ||
|
||
Language | ||
-------- | ||
- [Stabilised the `#[repr(transparent)]` attribute.][51562] This attribute | ||
allows a Rust newtype wrapper (`struct NewType<T>(T);`) to be represented as | ||
the inner type across Foreign Function Interface (FFI) boundaries. | ||
- [The keywords `pure`, `sizeof`, `alignof`, and `offsetof` have been unreserved | ||
and can now be used as identifiers.][51196] | ||
- [Stabilised the `GlobalAlloc` trait and `#[global_allocator]` | ||
attribute.][51241] This will allow users to specify a global allocator for | ||
their program. | ||
- [Unit test functions marked with the `#[test]` attribute can now return | ||
`Result<(), E: Debug>` in addition to `()`.][51298] | ||
- [Stabilised a `lifetime` specifier to `macro_rules!` allowing macros to easily | ||
target lifetimes.][50385] | ||
|
||
Compiler | ||
-------- | ||
- [Stabilised the `s` and `z` optimisation levels.][50265] These optimisations | ||
prioritise making smaller binary sizes. `z` is the same as `s` with the | ||
exception that it does not vectorise loops, which typically results in an even | ||
smaller binary. | ||
- [Stabilised the short error format.][49546] Specified with | ||
`--error-format=short` this option will provide a more compressed output of | ||
rust error messages. | ||
- [Added a lint warning when you have duplicated `macro_export`s.][50143] | ||
- [Reduced the number of allocations in the macro parser.][50855] This can | ||
improve compile times of macro heavy crates on average by 5%. | ||
|
||
Libraries | ||
--------- | ||
- [Implemented `Default` for `&mut str`.][51306] | ||
- [Implemented `From<bool>` for all integer and unsigned number types.][50554] | ||
- [Implemented `Extend` for `()`.][50234] | ||
- [The `Debug` implementation of `time::Duration` should now be more easily | ||
human readable.][50364] Previously a `Duration` of one second would printed as | ||
`Duration { secs: 1, nanos: 0 }` and will now be printed as `1s`. | ||
- [Implemented `From<&String>` for `Cow<str>`, `From<&Vec<T>>` for `Cow<[T]>`, | ||
`From<Cow<CStr>>` for `CString`, `From<CString>, From<CStr>, From<&CString>` | ||
for `Cow<CStr>`, `From<OsString>, From<OsStr>, From<&OsString>` for | ||
`Cow<OsStr>`, `From<&PathBuf>` for `Cow<Path>`, and `From<Cow<Path>>` | ||
for `PathBuf`.][50170] | ||
- [Implemented `Shl` and `Shr` for `Wrapping<u128>` | ||
and `Wrapping<i128>`.][50465] | ||
- [`DirEntry::metadata` now uses `fstatat` instead of `lstat` when | ||
possible.][51050] This can provide up to a 40% speed increase. | ||
- [Improved error messages when using `format!`.][50610] | ||
|
||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. #50465 insta-stabilized |
||
Stabilized APIs | ||
--------------- | ||
- [`Iterator::step_by`] | ||
- [`Path::ancestors`] | ||
- [`btree_map::Entry::or_default`] | ||
- [`fmt::Alignment`] | ||
- [`hash_map::Entry::or_default`] | ||
- [`iter::repeat_with`] | ||
- [`num::NonZeroU128`] | ||
- [`num::NonZeroU16`] | ||
- [`num::NonZeroU32`] | ||
- [`num::NonZeroU64`] | ||
- [`num::NonZeroU8`] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think |
||
- [`ops::RangeBounds`] | ||
- [`slice::SliceIndex`] | ||
- [`slice::from_mut`] | ||
- [`slice::from_ref`] | ||
- [`{Any + Send + Sync}::downcast_mut`] | ||
- [`{Any + Send + Sync}::downcast_ref`] | ||
- [`{Any + Send + Sync}::is`] | ||
|
||
Cargo | ||
----- | ||
- [Cargo will now no longer allow you to publish crates with build scripts that | ||
modify the `src` directory.][cargo/5584] The `src` directory in a crate should be | ||
considered to be immutable. | ||
|
||
Misc | ||
---- | ||
- [Stabilised the `suggestion_applicability` field in the json output.][50486] | ||
This will allow dev tools to check whether a code suggestion would apply | ||
to them. | ||
|
||
Compatibility Notes | ||
------------------- | ||
- [Rust will no longer consider trait objects with duplicated constraints to | ||
have implementations.][51276] For example the below code will now fail | ||
to compile. | ||
```rust | ||
trait Trait {} | ||
|
||
impl Trait + Send { | ||
fn test(&self) { println!("one"); } //~ ERROR duplicate definitions with name `test` | ||
} | ||
|
||
impl Trait + Send + Send { | ||
fn test(&self) { println!("two"); } | ||
} | ||
``` | ||
|
||
[49546]: https://github.com/rust-lang/rust/pull/49546/ | ||
[50143]: https://github.com/rust-lang/rust/pull/50143/ | ||
[50170]: https://github.com/rust-lang/rust/pull/50170/ | ||
[50234]: https://github.com/rust-lang/rust/pull/50234/ | ||
[50265]: https://github.com/rust-lang/rust/pull/50265/ | ||
[50364]: https://github.com/rust-lang/rust/pull/50364/ | ||
[50385]: https://github.com/rust-lang/rust/pull/50385/ | ||
[50465]: https://github.com/rust-lang/rust/pull/50465/ | ||
[50486]: https://github.com/rust-lang/rust/pull/50486/ | ||
[50554]: https://github.com/rust-lang/rust/pull/50554/ | ||
[50610]: https://github.com/rust-lang/rust/pull/50610/ | ||
[50855]: https://github.com/rust-lang/rust/pull/50855/ | ||
[51050]: https://github.com/rust-lang/rust/pull/51050/ | ||
[51196]: https://github.com/rust-lang/rust/pull/51196/ | ||
[51200]: https://github.com/rust-lang/rust/pull/51200/ | ||
[51241]: https://github.com/rust-lang/rust/pull/51241/ | ||
[51276]: https://github.com/rust-lang/rust/pull/51276/ | ||
[51298]: https://github.com/rust-lang/rust/pull/51298/ | ||
[51306]: https://github.com/rust-lang/rust/pull/51306/ | ||
[51562]: https://github.com/rust-lang/rust/pull/51562/ | ||
[cargo/5584]: https://github.com/rust-lang/cargo/pull/5584/ | ||
[`Iterator::step_by`]: https://doc.rust-lang.org/std/iter/trait.Iterator.html#method.step_by | ||
[`Path::ancestors`]: https://doc.rust-lang.org/std/path/struct.Path.html#method.ancestors | ||
[`btree_map::Entry::or_default`]: https://doc.rust-lang.org/std/collections/btree_map/enum.Entry.html#method.or_default | ||
[`fmt::Alignment`]: https://doc.rust-lang.org/std/fmt/enum.Alignment.html | ||
[`hash_map::Entry::or_default`]: https://doc.rust-lang.org/std/collections/btree_map/enum.Entry.html#method.or_default | ||
[`iter::repeat_with`]: https://doc.rust-lang.org/std/iter/fn.repeat_with.html | ||
[`num::NonZeroU128`]: https://doc.rust-lang.org/std/num/struct.NonZeroU128.html | ||
[`num::NonZeroU16`]: https://doc.rust-lang.org/std/num/struct.NonZeroU16.html | ||
[`num::NonZeroU32`]: https://doc.rust-lang.org/std/num/struct.NonZeroU32.html | ||
[`num::NonZeroU64`]: https://doc.rust-lang.org/std/num/struct.NonZeroU64.html | ||
[`num::NonZeroU8`]: https://doc.rust-lang.org/std/num/struct.NonZeroU8.html | ||
[`ops::RangeBounds`]: https://doc.rust-lang.org/std/ops/trait.RangeBounds.html | ||
[`slice::SliceIndex`]: https://doc.rust-lang.org/std/slice/trait.SliceIndex.html | ||
[`slice::from_mut`]: https://doc.rust-lang.org/std/slice/fn.from_mut.html | ||
[`slice::from_ref`]: https://doc.rust-lang.org/std/slice/fn.from_ref.html | ||
[`{Any + Send + Sync}::downcast_mut`]: https://doc.rust-lang.org/std/any/trait.Any.html#method.downcast_mut-2 | ||
[`{Any + Send + Sync}::downcast_ref`]: https://doc.rust-lang.org/std/any/trait.Any.html#method.downcast_ref-2 | ||
[`{Any + Send + Sync}::is`]: https://doc.rust-lang.org/std/any/trait.Any.html#method.is-2 | ||
|
||
|
||
Version 1.27.0 (2018-06-21) | ||
========================== | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be spelled as "Stabilized"? (also: "optimization", "prioritize", "vectorize")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kennytm Should it? I'm not from the US so when I'm writing it's stabilise, optimisation, prioritise, and vectorise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try to be consistent across the release notes. There is the "Stabilized APIs" section, but "Stabilised XYZ" is used everywhere else in the 1.27 notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think consistency is important, and while I hate to admit it, American spelling is the standard in tech
even though it's wrong.We should at least be using it where people might be ctrl-F-ing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I remember someone saying that
ize
is valid BrE spelling...I think it is more important to be consistent with our past selves than tech in general...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well, you could try to sneak it into an internationalization RFC... British-vs-American English!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be frank if we want to be consistent with our past these should be written as (see 1.27.0 and 1.26.0 release notes):
Or simply don't focus on the stabilization process
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps it might actually be worth creating a proper style guide for these, as an RFC or otherwise?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the release team can just create a style guide for their own purposes if need be. Don't think this rises to the level of needing an RFC.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Added this to the release team meeting agenda.