Updated RELEASES for 1.28.0 #51722
Updated RELEASES for 1.28.0 #51722
Conversation
rust-highfive
added
the
S-waiting-on-review
pietroalbini
added
the
T-release
RELEASES.md
Outdated
| - [Implemented `Extend` for `()`.][50234] | ||
| - [The `Debug` implementation of `time::Duration` should now be more easily | ||
| human readable.][50364] Previously a `Duration` of one second would printed as | ||
| `Duration { secs: 1, nanos: 0 }` will now be printed as `1s`. |
There was a problem hiding this comment.
Typo: should be "and will now" instead of "will now"
pietroalbini
added
beta-accepted
RELEASES.md
Outdated
|
|
||
| Language | ||
| -------- | ||
| - [Stabilised the `#[repr(transparent)]` attribute.][51562] This attribute |
There was a problem hiding this comment.
This should be spelled as "Stabilized"? (also: "optimization", "prioritize", "vectorize")
- We've got the header "Stabilized APIs"; overall 36 matches in this document
- The spelling "Stabilised" is only used 3 times before this PR (this PR introduced 6 "Stabilised")
- There's also a misspelled "Stablise" 🤔 in 1.26.0's note.
There was a problem hiding this comment.
@kennytm Should it? I'm not from the US so when I'm writing it's stabilise, optimisation, prioritise, and vectorise.
There was a problem hiding this comment.
We should try to be consistent across the release notes. There is the "Stabilized APIs" section, but "Stabilised XYZ" is used everywhere else in the 1.27 notes.
There was a problem hiding this comment.
I think consistency is important, and while I hate to admit it, American spelling is the standard in tech even though it's wrong.
We should at least be using it where people might be ctrl-F-ing.
There was a problem hiding this comment.
I remember someone saying that ize is valid BrE spelling...
I think it is more important to be consistent with our past selves than tech in general...
There was a problem hiding this comment.
Well, you could try to sneak it into an internationalization RFC... British-vs-American English!
There was a problem hiding this comment.
To be frank if we want to be consistent with our past these should be written as (see 1.27.0 and 1.26.0 release notes):
The
#[repr(transparent)]attribute is now stable.
Or simply don't focus on the stabilization process
Users can now use the
GlobalAlloctrait and#[global_allocator]attribute to specify a global allocator for their program.
There was a problem hiding this comment.
Perhaps it might actually be worth creating a proper style guide for these, as an RFC or otherwise?
There was a problem hiding this comment.
I think the release team can just create a style guide for their own purposes if need be. Don't think this rises to the level of needing an RFC.
There was a problem hiding this comment.
Yeah. Added this to the release team meeting agenda.
RELEASES.md
Outdated
| Cargo | ||
| ----- | ||
| - [Cargo will now no longer allow you to publish crates with build scripts that | ||
| modify the `src` directory.][5584] The `src` directory in a crate should be |
There was a problem hiding this comment.
The tag should better be [cargo/5584]
RELEASES.md
Outdated
| - [`DirEntry::metadata` now uses `fstatat` instead of `lstat` when | ||
| possible.][51050] This can provide up to a 40% speed increase. | ||
| - [Improved error messages when using `format!`.][50610] | ||
|
|
There was a problem hiding this comment.
#50465 insta-stabilized impl {Shl, Shr} for Wrapping<{u128, i128}>.
| - [`num::NonZeroU16`] | ||
| - [`num::NonZeroU32`] | ||
| - [`num::NonZeroU64`] | ||
| - [`num::NonZeroU8`] |
There was a problem hiding this comment.
I think num::NonZeroUsize is missing here.
|
Ping from triage @Mark-Simulacrum! Should we merge this? |
|
@bors r+ rollup Thanks! |
|
📌 Commit dab257f has been approved by |
bors
added
S-waiting-on-bors
Updated RELEASES for 1.28.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release
Updated RELEASES for 1.28.0 [Rendered](https://github.com/Aaronepower/rust/blob/master/RELEASES.md) r? @Mark-Simulacrum cc @rust-lang/release
Rollup of 7 pull requests Successful merges: - #51612 (NLL: fix E0594 "change to mutable ref" suggestion) - #51722 (Updated RELEASES for 1.28.0) - #52064 (Clarifying how the alignment of the struct works) - #52149 (Add #[repr(transparent)] to Atomic* types) - #52151 (Trait impl settings) - #52171 (Correct some codegen stats counter inconsistencies) - #52195 (rustc: Avoid /tmp/ in graphviz writing) Failed merges: - #52164 (use proper footnote syntax for references) r? @ghost
pietroalbini
removed
the
beta-nominated
[beta] Rollup backports Merged and approved: * #51722: Updated RELEASES for 1.28.0 * #52193: step_by: leave time of item skip unspecified * #52194: Remove rustdoc's plugins feature * #52196: rustdoc: Hide struct and enum variant constructor imports * #52310: Backport 1.27.1 release notes to master r? @ghost
Rendered
r? @Mark-Simulacrum
cc @rust-lang/release