proc_macro: Tweak doc comments and negative literals #49545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit tweaks the tokenization of a doc comment to use `#[doc = "..."]` like `macro_rules!` does (instead of treating it as a `Literal` token). Additionally it fixes treatment of negative literals in the compiler, for exapmle `Literal::i32(-1)`. The current fix is a bit of a hack around the current compiler implementation, providing a fix at the proc-macro layer rather than the libsyntax layer.
eddyb
reviewed
Apr 1, 2018
| tt!(TokenNode::Literal(self::Literal(Literal(Lit::Str_(c), None)))), | ||
| ].into_iter().collect(); | ||
| stack.push(tt!(TokenNode::Group(Delimiter::Bracket, stream))); | ||
| op!('#') |
There was a problem hiding this comment.
Oh this is easier than I expected. Can't wait to rebase over it!
|
@bors r+ |
|
📌 Commit ec1a8f0 has been approved by |
bors
added
the
S-waiting-on-bors
bors
added a commit
that referenced
this pull request
Apr 1, 2018
proc_macro: Tweak doc comments and negative literals This commit tweaks the tokenization of a doc comment to use `#[doc = "..."]` like `macro_rules!` does (instead of treating it as a `Literal` token). Additionally it fixes treatment of negative literals in the compiler, for exapmle `Literal::i32(-1)`. The current fix is a bit of a hack around the current compiler implementation, providing a fix at the proc-macro layer rather than the libsyntax layer. Closes #48889
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Apr 2, 2018
yui-knk
added a commit
to yui-knk/rust
that referenced
this pull request
Dec 2, 2018
Currently libproc_macro does not use `DotEq` token. rust-lang#49545 changed libproc_macro to not generate `DotEq` token.
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Dec 3, 2018
…, r=petrochenkov Remove not used `DotEq` token Currently libproc_macro does not use `DotEq` token. rust-lang#49545 changed libproc_macro to not generate `DotEq` token.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit tweaks the tokenization of a doc comment to use
#[doc = "..."]like
macro_rules!does (instead of treating it as aLiteraltoken).Additionally it fixes treatment of negative literals in the compiler, for
exapmle
Literal::i32(-1). The current fix is a bit of a hack around thecurrent compiler implementation, providing a fix at the proc-macro layer rather
than the libsyntax layer.
Closes #48889