Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Attribute::is_sugared_doc #389

Closed
dtolnay opened this issue Apr 2, 2018 · 1 comment
Closed

Remove Attribute::is_sugared_doc #389

dtolnay opened this issue Apr 2, 2018 · 1 comment
Labels
breaking change
Milestone
0.15

Comments

@dtolnay
Copy link
Owner

dtolnay commented Apr 2, 2018

As of rust-lang/rust#49545 proc macros can no longer tell the difference between sugared vs attribute doc comments, just like macro_rules currently cannot. In Syn 0.13 I believe the is_sugared_doc field is always set to false by the parser.
@dtolnay dtolnay added this to the 0.14 milestone Apr 2, 2018
@Bert-Proesmans Bert-Proesmans mentioned this issue Apr 4, 2018
Closed
@dtolnay dtolnay mentioned this issue Apr 4, 2018
Closed
@dtolnay dtolnay modified the milestones: 0.14, 0.15 May 21, 2018
@dtolnay
Copy link
Owner Author

dtolnay commented Sep 1, 2018

Fixed in fe58330, will be released in 0.15.

@dtolnay dtolnay closed this as completed Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breaking change
Projects
None yet
Milestone
0.15
Development

No branches or pull requests
1 participant
@dtolnay