Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add per-stage RUSTFLAGS: RUSTFLAGS_STAGE_{0,1,2} and RUSTFLAGS_STAGE_NOT_0 #47836

Merged
merged 1 commit into from
Jan 30, 2018
Merged

Add per-stage RUSTFLAGS: RUSTFLAGS_STAGE_{0,1,2} and RUSTFLAGS_STAGE_NOT_0 #47836

merged 1 commit into from
Jan 30, 2018

Conversation

Mark-Simulacrum
Copy link
Member

Fixes #47658.

r? @alexcrichton

@Mark-Simulacrum
Copy link
Member Author

cc @nikomatsakis @eddyb

@alexcrichton
Copy link
Member

r=me, but looks like tidy is failing?

@kennytm kennytm added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jan 29, 2018
@Mark-Simulacrum
Copy link
Member Author

@bors r=alexcrichton

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 29, 2018
@bors
Copy link
Contributor

bors commented Jan 29, 2018

📌 Commit e09a8bd has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Jan 29, 2018

⌛ Testing commit e09a8bd with merge a242a34462f1d3e553e5d0111bbe21a32686c1dd...

@bors
Copy link
Contributor

bors commented Jan 29, 2018

💔 Test failed - status-appveyor

@kennytm
Copy link
Member

kennytm commented Jan 29, 2018

@bors retry #46903

kennytm added a commit to kennytm/rust that referenced this pull request Jan 29, 2018
@kennytm
Rollup merge of rust-lang#47836 - Mark-Simulacrum:stage-flags, r=alex…
1705668 
…crichton

Add per-stage RUSTFLAGS: RUSTFLAGS_STAGE_{0,1,2} and RUSTFLAGS_STAGE_NOT_0

Fixes rust-lang#47658.

r? @alexcrichton
@kennytm kennytm mentioned this pull request Jan 29, 2018
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Jan 30, 2018
@kennytm
Rollup merge of rust-lang#47836 - Mark-Simulacrum:stage-flags, r=alex…
e8868bd 
…crichton

Add per-stage RUSTFLAGS: RUSTFLAGS_STAGE_{0,1,2} and RUSTFLAGS_STAGE_NOT_0

Fixes rust-lang#47658.

r? @alexcrichton
@kennytm kennytm mentioned this pull request Jan 30, 2018
Merged
bors added a commit that referenced this pull request Jan 30, 2018
@bors
Auto merge of #47870 - kennytm:rollup, r=kennytm
def3269 
Rollup of 12 pull requests

- Successful merges: #47515, #47603, #47718, #47732, #47760, #47780, #47822, #47826, #47836, #47839, #47853, #47855
- Failed merges:
@bors bors merged commit e09a8bd into rust-lang:master Jan 30, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the stage-flags branch June 8, 2019 13:51
@Aaron1011 Aaron1011 mentioned this pull request May 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Mark-Simulacrum @alexcrichton @bors @kennytm