Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade jemalloc to 5.0.1 #45163

Closed
wants to merge 1 commit into from
Closed

Conversation

sfackler
Copy link
Member

The build script needs to run autoconf which should be fine, right?

We're building against 5.0.1 with jemalloc/jemalloc@0a4f5a7 cherry-picked on top.

r? @alexcrichton

@sfackler
Copy link
Member Author

Ok, so it looks like requiring autoconf is a problem. I've pushed an extra commit de-ignoring the config file and check it in.

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Oct 10, 2017

📌 Commit e684700 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Oct 11, 2017

⌛ Testing commit e684700ce294fbc26e8a92768201f9968a2bf55f with merge 2d9a88b19fc83655778c7a4ea2d8c9106c4cb362...

@bors
Copy link
Contributor

bors commented Oct 11, 2017

💔 Test failed - status-travis

@sfackler
Copy link
Member Author

@bors retry

@bors
Copy link
Contributor

bors commented Oct 11, 2017

⌛ Testing commit e684700ce294fbc26e8a92768201f9968a2bf55f with merge a6847a179074e0533cb52ec9d2651bc724870aa7...

@bors
Copy link
Contributor

bors commented Oct 11, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Oct 11, 2017

There is no O_CLOEXEC?

[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/pages.c: In function 'os_overcommits_proc':
[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/pages.c:357:6: error: 'O_CLOEXEC' undeclared (first use in this function)
[00:02:12]       O_CLOEXEC);
[00:02:12]       ^
...
[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/prof.c: In function 'prof_open_maps':
[00:02:12] /checkout/src/liballoc_jemalloc/../jemalloc/src/prof.c:1412:34: error: 'O_CLOEXEC' undeclared (first use in this function)
[00:02:12]   mfd = open(filename, O_RDONLY | O_CLOEXEC);
[00:02:12]                                   ^

@sfackler
Copy link
Member Author

We build dists on a version of Linux from before CLOEXEC was created. Jemalloc's dev branch has a patch to deal with this but it's not in 5.0.1: jemalloc/jemalloc@0975b88.

Hopefully it applies cleanly.

@sfackler
Copy link
Member Author

@bors retry

@sfackler
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Oct 11, 2017

📌 Commit 4f65e18 has been approved by alexcrichton

@kennytm
Copy link
Member

kennytm commented Oct 11, 2017

@bors r-

Build failed on android, some problem with the TLS section. (Travis log: https://travis-ci.org/rust-lang/rust/jobs/286655880)

[00:44:38] /checkout/src/liballoc_jemalloc/../jemalloc/src/tsd.c:20:35: error: __emutls_t.tsd_tls causes a section type conflict with tsd_tls
[00:44:38]  __thread tsd_t JEMALLOC_TLS_MODEL tsd_tls = TSD_INITIALIZER;
[00:44:38]                                    ^
[00:44:38] /checkout/src/liballoc_jemalloc/../jemalloc/src/tsd.c:20:35: note: 'tsd_tls' was declared here
[00:44:38] make: *** [src/tsd.sym.o] Error 1
[00:44:38] make: *** Waiting for unfinished jobs....
[00:44:38] 
[00:44:38] �[m�[m�[33m�[1mwarning:�[m build failed, waiting for other jobs to finish...
[00:44:41] �[m�[m�[31m�[1merror:�[m build failed
[00:44:41] thread 'main' panicked at 'command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:44:41] expected success, got: exit code: 101', /checkout/src/bootstrap/compile.rs:883:8
[00:44:41] note: Run with `RUST_BACKTRACE=1` for a backtrace.
[00:44:41] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap dist --target arm-linux-androideabi,armv7-linux-androideabi,i686-linux-android,aarch64-linux-android,x86_64-linux-android
[00:44:41] Build completed unsuccessfully in 0:42:32

@sfackler
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 12, 2017

⌛ Trying commit 1b576406f6506d0849f7f98097d7ea3ecd2750ae with merge a1559cfb4c9081f1911cb70385a14083c144e93c...

@bors
Copy link
Contributor

bors commented Oct 12, 2017

💔 Test failed - status-travis

@sfackler
Copy link
Member Author

@bors try

@bors
Copy link
Contributor

bors commented Oct 12, 2017

⌛ Trying commit 1d78cc2 with merge 116157c...

bors added a commit that referenced this pull request Oct 12, 2017
Upgrade jemalloc to 5.0.1

The build script needs to run autoconf which should be fine, right?

We're building against 5.0.1 with jemalloc/jemalloc@0a4f5a7 cherry-picked on top.

r? @alexcrichton
@sfackler
Copy link
Member Author

@bors r=alexcrichton

@bors
Copy link
Contributor

bors commented Oct 12, 2017

📌 Commit 648e44f has been approved by alexcrichton

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Oct 12, 2017
bors added a commit that referenced this pull request Oct 12, 2017
[WIP] Rollup of 10 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231
- Failed merges: #45138
@kennytm
Copy link
Member

kennytm commented Oct 12, 2017

@sfackler
Copy link
Member Author

Grr, ok thanks.

@sfackler
Copy link
Member Author

I'm going to close this since I don't really want to figure out how to get the Android setup working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants