Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rustc documentation typo #45105

Merged
merged 1 commit into from
Oct 13, 2017
Merged

Fix rustc documentation typo #45105

merged 1 commit into from
Oct 13, 2017

Conversation

camsteffen
Copy link
Contributor

I'm new to rustc but this looks like a typo.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@camsteffen camsteffen changed the title Fix documentation typo Fix rustc documentation typo Oct 8, 2017
@carols10cents
Copy link
Member

Thanks for the PR! We’ll periodically check in on it to make sure that @pnkfelix or someone else from the team reviews it soon.

@carols10cents carols10cents added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 9, 2017
@pnkfelix
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 11, 2017

📌 Commit e6728ec has been approved by pnkfelix

@kennytm kennytm mentioned this pull request Oct 11, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 11, 2017
@kennytm
Rollup merge of rust-lang#45105 - camsteffen:patch-2, r=pnkfelix
a460ceb 
Fix rustc documentation typo

I'm new to rustc but this looks like a typo.
@kennytm kennytm mentioned this pull request Oct 11, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge of rust-lang#45105 - camsteffen:patch-2, r=pnkfelix
6654979 
Fix rustc documentation typo

I'm new to rustc but this looks like a typo.
@kennytm kennytm mentioned this pull request Oct 12, 2017
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Oct 12, 2017
@kennytm
Rollup merge of rust-lang#45105 - camsteffen:patch-2, r=pnkfelix
ff53dc7 
Fix rustc documentation typo

I'm new to rustc but this looks like a typo.
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=<try>
6f8b325 
[WIP] Rollup of 10 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45163, #45166, #45172, #45190, #45231
- Failed merges: #45138
bors added a commit that referenced this pull request Oct 12, 2017
@bors
Auto merge of #45233 - kennytm:rollup, r=kennytm
64ee7d1 
Rollup of 9 pull requests

- Successful merges: #44989, #45005, #45049, #45105, #45121, #45166, #45172, #45190, #45231
- Failed merges: #45138
@bors bors merged commit e6728ec into rust-lang:master Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@camsteffen @rust-highfive @carols10cents @pnkfelix @bors