Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

travis: Pass --enable-llvm-static-stdcpp #39132

Merged
merged 1 commit into from
Jan 21, 2017

Conversation

alexcrichton
Copy link
Member

All our releases are compiled with this, so let's be sure to do so whenever
DEPLOY is set. This'll ensure that we don't have dynamic dependencies on
libstdc++ which LLVM depends on, but instead we link it all statically to have
more portable binaries.

All our releases are compiled with this, so let's be sure to do so whenever
`DEPLOY` is set. This'll ensure that we don't have dynamic dependencies on
libstdc++ which LLVM depends on, but instead we link it all statically to have
more portable binaries.
@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@japaric
Copy link
Member

japaric commented Jan 17, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Jan 17, 2017

📌 Commit 1080a69 has been approved by japaric

@japaric japaric assigned japaric and unassigned nikomatsakis Jan 17, 2017
alexcrichton added a commit to alexcrichton/rust that referenced this pull request Jan 20, 2017
…paric

travis: Pass --enable-llvm-static-stdcpp

All our releases are compiled with this, so let's be sure to do so whenever
`DEPLOY` is set. This'll ensure that we don't have dynamic dependencies on
libstdc++ which LLVM depends on, but instead we link it all statically to have
more portable binaries.
@alexcrichton
Copy link
Member Author

@bors: r-

This doesn't pass on OSX or Windows (where we basically don't support this option). Fixed in the rollup which I hope to land today but we'll see how that goes.

bors added a commit that referenced this pull request Jan 20, 2017
bors added a commit that referenced this pull request Jan 21, 2017
@bors bors merged commit 1080a69 into rust-lang:master Jan 21, 2017
@alexcrichton alexcrichton deleted the static-libstdcpp branch January 21, 2017 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants