-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
travis: Add i586 linux and i686 musl #39068
Conversation
r? @brson (rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #39042) made this pull request unmergeable. Please resolve the merge conflicts. |
This commit expands the existing x86_64-musl entry in the Travis matrix to also build/test i586-unknown-linux-gnu and i686-unknown-linux-musl. cc rust-lang#38531 Closes rust-lang#39053
173ad8a
to
6162637
Compare
# looking like the register values for ESP/EBP were indeed incorrect (swapped) | ||
# in the source. Similar commits in libunwind (r280099 and r282589) have noticed | ||
# this for other platforms, and we just need to realize it for musl linux as | ||
# well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
holy shit
@bors r+ |
📌 Commit 6162637 has been approved by |
⌛ Testing commit 6162637 with merge 1cf8da1... |
💔 Test failed - status-appveyor |
travis: Add i586 linux and i686 musl This commit expands the existing x86_64-musl entry in the Travis matrix to also build/test i586-unknown-linux-gnu and i686-unknown-linux-musl. cc rust-lang#38531 Closes rust-lang#35599 Closes rust-lang#39053
@bors: retry
* network error
…On Fri, Jan 20, 2017 at 8:00 AM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.1631>
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#39068 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95FJ1JbAK3srBrkBGvrZ1HqCdZGoEks5rUNoggaJpZM4LjuTU>
.
|
@bors: r-
|
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
With a tip from the #llvm IRC channel looks like all we needed was to enable frame pointers. I have done so and it fixes the failures I previously saw. The fix missed the most recent revision of the rollup, so I'll probably send a follow-up PR to enable testing for i686 musl. |
Rollup of 28 pull requests - Successful merges: #38603, #38761, #38842, #38847, #38955, #38966, #39062, #39068, #39077, #39111, #39112, #39114, #39118, #39120, #39132, #39135, #39138, #39142, #39143, #39146, #39157, #39166, #39167, #39168, #39179, #39184, #39195, #39197 - Failed merges: #39060, #39145
This commit expands the existing x86_64-musl entry in the Travis matrix to also
build/test i586-unknown-linux-gnu and i686-unknown-linux-musl.
cc #38531
Closes #35599
Closes #39053