-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compiler error E0076 to use new error format #36050
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Thanks for the PR! This looks like a good start. The next step is to update the unit test so that it tests the new label. You can read how to do this by looking at the Extra Credit part of the blog post. |
74b8fea
to
3286f2d
Compare
done edit: not attempting bonus anymore, not that straightforward |
@jonathandturner |
Looks good. One last thing. Can you squash your 2 commits down to 1 commit? After that, I think it's ready. |
3286f2d
to
d3a6ea5
Compare
Looks good! @bors r+ rollup |
📌 Commit d3a6ea5 has been approved by |
…andturner Update compiler error E0076 to use new error format Fixes rust-lang#35221 part of rust-lang#35233 r? @jonathandturner
@jonathandturner |
…andturner Update compiler error E0076 to use new error format Fixes rust-lang#35221 part of rust-lang#35233 r? @jonathandturner
…andturner Update compiler error E0076 to use new error format Fixes rust-lang#35221 part of rust-lang#35233 r? @jonathandturner
Fixes #35221 part of #35233
r? @jonathandturner