Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update compiler error E0076 to use new error format #36050

Merged
merged 1 commit into from
Aug 31, 2016

Conversation

abhiQmar
Copy link
Contributor

@abhiQmar abhiQmar commented Aug 27, 2016

Fixes #35221 part of #35233

r? @jonathandturner

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pnkfelix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@sophiajt
Copy link
Contributor

Thanks for the PR!

This looks like a good start. The next step is to update the unit test so that it tests the new label. You can read how to do this by looking at the Extra Credit part of the blog post.

@abhiQmar
Copy link
Contributor Author

abhiQmar commented Aug 27, 2016

done
Can you please point me in a direction with the bonus on this one ?

edit: not attempting bonus anymore, not that straightforward

@abhiQmar
Copy link
Contributor Author

@jonathandturner
Do I need to do add anything?

@sophiajt
Copy link
Contributor

Looks good. One last thing. Can you squash your 2 commits down to 1 commit? After that, I think it's ready.

@sophiajt
Copy link
Contributor

Looks good!

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Aug 30, 2016

📌 Commit d3a6ea5 has been approved by jonathandturner

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 30, 2016
…andturner

Update compiler error E0076 to use new error format

Fixes rust-lang#35221 part of rust-lang#35233

r? @jonathandturner
@abhiQmar
Copy link
Contributor Author

@jonathandturner
All the tests were passing on my machine. Has the master moved, should I take a pull and fix them ?

sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
…andturner

Update compiler error E0076 to use new error format

Fixes rust-lang#35221 part of rust-lang#35233

r? @jonathandturner
sophiajt pushed a commit to sophiajt/rust that referenced this pull request Aug 31, 2016
…andturner

Update compiler error E0076 to use new error format

Fixes rust-lang#35221 part of rust-lang#35233

r? @jonathandturner
bors added a commit that referenced this pull request Aug 31, 2016
@bors bors merged commit d3a6ea5 into rust-lang:master Aug 31, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants