accumulate vector and assert for RangeFrom and RangeInclusive examples #35758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Thanks! @bors: r+ rollup |
|
📌 Commit 6c0186d has been approved by |
| /// println!("{}", i); | ||
| /// } | ||
| /// let result: Vec<_> = (0..).step_by(2).take(5).collect(); | ||
| /// assert_eq!(result, vec![0, 2, 4, 6, 8]); |
There was a problem hiding this comment.
I think removing the annotation changes it from u8 to implicitly i32, not that it matters.
There was a problem hiding this comment.
It simplified the example without harming so I didn't bother with it.
There was a problem hiding this comment.
Yeah, sorry, I should have been clear. Removing the annotation isn't a no-op for the code, but it's unnecessary for explaining the behavior of step_by in this case. A u8 example may be important for explaining overflow behavior though...
|
☔ The latest upstream changes (presumably #35747) made this pull request unmergeable. Please resolve the merge conflicts. |
matthew-piziak
force-pushed
the
vec-assert-over-println-remaining
branch
from
6c0186d to
95c53b1
Compare
|
@bors: r+ rollup |
|
📌 Commit 95c53b1 has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 19, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 19, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 20, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
|
Please squash your two last commits. |
matthew-piziak
force-pushed
the
vec-assert-over-println-remaining
branch
2 times, most recently
from
7636be9 to
28f057d
Compare
|
@bors: r=GuillaumeGomez rollup |
|
📌 Commit 28f057d has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 25, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Aug 26, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
|
⌛ Testing commit 28f057d with merge 1d3d70e... |
|
💔 Test failed - auto-win-gnu-32-opt-rustbuild |
PR rust-lang#35695 for `Range` was approved, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`. add `fn main` wrappers to enable Rust Playground "Run" button
matthew-piziak
force-pushed
the
vec-assert-over-println-remaining
branch
from
28f057d to
50e0fbc
Compare
|
Once buildbot is fixed, r+ you get! |
|
@bors: r=GuillaumeGomez rollup |
|
📌 Commit 50e0fbc has been approved by |
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 30, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this pull request
Aug 31, 2016
…tln-remaining, r=GuillaumeGomez accumulate vector and assert for RangeFrom and RangeInclusive examples PR rust-lang#35695 for `Range` was merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation for `RangeFrom` and `RangeInclusive`. It also removes what looks to be an erroneously commented line for `#![feature(step_by)]`, and an unnecessary primitive-type annotation in `0u8..`.
bors
added a commit
that referenced
this pull request
Aug 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR #35695 for
Rangewas merged, so it seems that this side-effect-free style is preferred for Range* examples. This PR performs the same translation forRangeFromandRangeInclusive. It also removes what looks to be an erroneously commented line for#![feature(step_by)], and an unnecessary primitive-type annotation in0u8...