Update compiler error 0034 to use new format.

[athulappadan]

Part of #35233
Addresses #35205

r? @jonathandturner

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[athulappadan]

I would like to know what could be the reason why the checks failed.

[sanxiyn]

Rust forbids tab characters in source code.

[sophiajt]

Thanks for the PR!

I was just about to start releasing some of the older codes so more people could volunteer, and you beat me to it :)

Like @sanxiyn pointed out, you need to pass a tidy check for a patch to be accepted. You can run this by doing:

python src/bootstrap/bootstrap.py --stage 1 --step check-tidy

You'll also need to update the unit test to check for this new label. By default, labels are not tested. You need to add at least one label for all labels in a test to be tested. You can read about how to do this in my blog post under Extra Credit: http://www.jonathanturner.org/2016/08/helping-out-with-rust-errors.html

[athulappadan]

Thanks for the reply. Will fix it soon.

[athulappadan]

I am finding it difficult to understand how to give the proper labels in the test cases, even after going through the blog. Please suggest some useful tips/materials to understand the same.

@jonathandturner

[sophiajt]

@athulappadan - you can look at some of the PRs that have already gone through to see how. For example:

https://github.com/rust-lang/rust/pull/35961/files

Notice how the files in src/test/compile-fail get updated to include testing for the new labels? For each PR that updates the errors, we want to check for those labels using this technique.

[athulappadan]

should be fixed by #36009