-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E0034 needs to be updated to new format #35205
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
Comments
sophiajt
added
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
A-diagnostics
Area: Messages for errors, warnings, and lints
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
labels
Aug 2, 2016
Let me work on this one. |
@athulappadan - I haven't heard anything on this from the first person who volunteered, so feel free to take it. |
This was referenced Aug 26, 2016
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this issue
Aug 30, 2016
Update compiler error 0034 to use new format. Part of rust-lang#35233 Addresses rust-lang#35205 r? @jonathandturner
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this issue
Aug 30, 2016
Update compiler error 0034 to use new format. Part of rust-lang#35233 Addresses rust-lang#35205 r? @jonathandturner
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this issue
Aug 31, 2016
Update compiler error 0034 to use new format. Part of rust-lang#35233 Addresses rust-lang#35205 r? @jonathandturner
sophiajt
pushed a commit
to sophiajt/rust
that referenced
this issue
Aug 31, 2016
Update compiler error 0034 to use new format. Part of rust-lang#35233 Addresses rust-lang#35205 r? @jonathandturner
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-diagnostics
Area: Messages for errors, warnings, and lints
E-easy
Call for participation: Easy difficulty. Experience needed to fix: Not much. Good first issue.
E-mentor
Call for participation: This issue has a mentor. Use #t-compiler/help on Zulip for discussion.
From: src/test/compile-fail/E0034.rs
The E0034 error message needs a span_label, changing it from:
to:
Bonus: there may be additional fixes we can do to improve E0034 as well. We could explore underlining the candidates as secondary notes rather than as completely separate notes as one possibility.
The text was updated successfully, but these errors were encountered: