Updated E0394 & E0422 to new format

[knight42]

Fixes #35692 and #35700, as part of #35233.

r? @jonathandturner

[rust-highfive]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

[sophiajt]

Thanks for the PR!

Looking good so far. The next step is to update the unit tests. There's a quirk in the unit tester in that it will only tests a label if you add at least one NOTE to the unit test. I talk about it in the blog post in the Extra Credit section.

With the unit tests, we should be good to go.

[knight42]

@jonathandturner
but I ran python src/bootstrap/bootstrap.py --step check-cfail --stage 1 locally and passed all the tests...

[sophiajt]

@knight42 - I know, it's confusing :-/ You'll need to update the test for the labels to be checked.

[knight42]

I have tried to grep -R E0422 src/test and grep -R E0394 src/test, but got nothing except compile-fail/E0422.rs and compile-fail/E0394.rs. Should I add extra tests?

[sophiajt]

You can just update those two tests. As long as there are tests that test the label, we're good.

[knight42]

@jonathandturner Thanks for your patience. I updated my last commit. Does this look good now?

[sophiajt]

That's exactly the right direction. Once you do the same for E0422, I think we're ready.

[knight42]

should be fixed this time...

[sophiajt]

Looks good!

@bors r+ rollup

[bors]

📌 Commit 3caa451 has been approved by jonathandturner