Clarify type declaration language in Associated Types docs #35595
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -67,7 +67,7 @@ trait Graph { | |||
| Simple enough. Associated types use the `type` keyword, and go inside the body | |||
| of the trait, with the functions. | |||
|
|
|||
| These `type` declarations can have all the same thing as functions do. For example, | |||
| These `type` declarations work in the same way as those for functions do. For example, | |||
| if we wanted our `N` type to implement `Display`, so we can print the nodes out, | |||
There was a problem hiding this comment.
I would:
These
typedeclarations work the same way as those for functions.
There was a problem hiding this comment.
I would:
These type declarations work in the same way as they do for functions.
Thoughts, both of you? The original sentence is very bad :(
There was a problem hiding this comment.
I think @tshepang's version is clearer (I assumed the original was just written late at night / in a state of exhaustion)
|
@bors: r+ rollup thank you! |
|
📌 Commit 31da7f6 has been approved by |
…=steveklabnik Clarify type declaration language in Associated Types docs A small fix for the Associated Types docs r? @steveklabnik
…=steveklabnik Clarify type declaration language in Associated Types docs A small fix for the Associated Types docs r? @steveklabnik
A small fix for the Associated Types docs
r? @steveklabnik