Add to resolve's public API
#34655
Add to resolve's public API
#34655
Conversation
|
|
| } | ||
| } | ||
| } | ||
|
|
||
| None | ||
| } | ||
|
|
||
| pub fn resolve_ident_in_module_lexical_scope( |
There was a problem hiding this comment.
Could you comment to explain what 'module lexical scope' means
jseyfried
force-pushed
the
improve_resolver_api
branch
6 times, most recently
from
2e73eec to
54698df
Compare
jseyfried
force-pushed
the
improve_resolver_api
branch
from
54698df to
6e0bd44
Compare
|
@nrc After thinking about this some more, I reimplemented this PR to provide a more powerful API. |
|
iirc, |
|
otherwise, this lgtm |
|
@nrc Hmm, we don't have a testing framework for There is no use for this function in the However, we don't have a way to get a |
|
OK, that sounds like a lot of work. Could you file an issue for a test so we don't forget, then add a |
|
Sounds good, done. @bors r=nrc |
|
📌 Commit 58dd06d has been approved by |
|
⌛ Testing commit 58dd06d with merge b4e11c2... |
Add to `resolve`'s public API This adds a public method `with_module_lexical_scope` to `Resolver` to allow users to resolve a path in the lexical scope of an arbitrary module. r? @nrc
This adds a public method
with_module_lexical_scopetoResolverto allow users to resolve a path in the lexical scope of an arbitrary module.r? @nrc