Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve: resolver.with_module_lexical_scope() needs testing #34673

Closed
jseyfried opened this issue Jul 5, 2016 · 4 comments
Closed

resolve: resolver.with_module_lexical_scope() needs testing #34673

jseyfried opened this issue Jul 5, 2016 · 4 comments
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.

Comments

@jseyfried
Copy link
Contributor

cc @nrc
@jseyfried
Copy link
Contributor Author

cc @JohnHeitmann (c.f. #34655)

@Mark-Simulacrum
Copy link
Member

@jseyfried This function is unused within this repository; can you comment on what kind of testing you mean? Is this compile-fail/run-pass tests? I don't think so; since it's unused.

@jseyfried
Copy link
Contributor Author

@Mark-Simulacrum Unit testing that it behaves correctly.

@Mark-Simulacrum Mark-Simulacrum added A-testsuite Area: The testsuite used to check the correctness of rustc E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added. A-resolve Area: Name/path resolution done by `rustc_resolve` specifically and removed A-testsuite Area: The testsuite used to check the correctness of rustc labels Jun 22, 2017
@Mark-Simulacrum Mark-Simulacrum added the C-enhancement Category: An issue proposing an enhancement or a PR with one. label Jul 25, 2017
@JohnTitor
Copy link
Member

Triage: I'm going to close as outdated, since I cannot find this method in rustc_resolve now. If the method still exists somewhere and I overlook it, feel free to re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-resolve Area: Name/path resolution done by `rustc_resolve` specifically C-enhancement Category: An issue proposing an enhancement or a PR with one. E-needs-test Call for participation: An issue has been fixed and does not reproduce, but no test has been added.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Mark-Simulacrum @jseyfried @JohnTitor