Implement slicing syntax. #17318
Merged
Implement slicing syntax. #17318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| unsafe { | ||
| assert!(COUNT == 8); | ||
| } | ||
| } |
|
Can you add a run-fail test or two to make sure that cleanups run if failure happens during evaluation of a slice argument (for example, that the temporary generated by the LHS of |
|
Otherwise looks good, will rereview with those changes. Awesome work 👍 |
|
@pcwalton re-r? I wasn't exactly sure what cleanup tests to add - does the one I added do what you want? And are there more things we should test? |
|
@nick29581 I think @pcwalton meant |
`expr[]`, `expr[expr..]`, `expr[..expr]`,`expr[expr..expr]` Uses the Slice and SliceMut traits. Allows ... as well as .. in range patterns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
expr[],expr[expr..],expr[..expr],expr[expr..expr]Uses the Slice and SliceMut traits.
Allows ... as well as .. in range patterns.
r? @pcwalton (or anyone else)
closes #17177