-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement overloaded slice notation #17177
Comments
Nominating, I believe this is a very important syntax to have. |
cc #17177, this may just be a dupe of that. |
@alexcrichton This is #17177 :-) Note that if we end up making |
oops: cc #14983 |
We can add this syntax backwards-compatibly. Assigning P-low, not 1.0 blocker. |
I am implementing |
@nick29581 Awesome! |
and #17295 |
@nick29581 You listed three issues #17293 #17273 and #17295 but only the first among them is still open. Is that the reason why we still need |
@nick29581 I see, so the slicing notation is tracked by 0439-cmp-ops-reform rather than 0198-slice-notation now. |
@nodakai I wouldn't say either RFC tracks slicing notation - both contain aspects of the design |
Fix Run lens showing when lenses are disabled I have disabled Rust Analyzer lenses in my VSCode settings, but noticed that the `Run` lens still showed. This surprised me, as the docs for `lens.run.enable` [state that it only applies when `lens.enable` is set](https://github.com/rust-lang/rust-analyzer/blob/25f59be62f6b915b44a4c2ec2defca56a5f766c1/crates/rust-analyzer/src/config.rs#L353-L355). I then found that where we set `LensConfig::run`, we don't check `lens_enable` like for the other settings. [We did this previously](https://github.com/rust-lang/rust-analyzer/blob/eab385e1f64f8e3b861effe91432785f8030191b/crates/rust-analyzer/src/config.rs#L1649), so this seems like a regression from refactoring. This PR tries to fix that.
Tracking issue for rust-lang/rfcs#198
The text was updated successfully, but these errors were encountered: