Skip to content

Add test for the missing Clone requirement for Cow slices - #162619

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-141241-cow-clone-diagnostic-test
Sep 11, 2026
Merged

Add test for the missing Clone requirement for Cow slices#162619
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
chenyukang:yukang-fix-141241-cow-clone-diagnostic-test

Conversation

@chenyukang

@chenyukang chenyukang commented Sep 11, 2026 •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Fixes #141241

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Sep 11, 2026
@rustbot

rustbot commented Sep 11, 2026

Copy link
Copy Markdown
Collaborator

r? @jieyouxu

rustbot has assigned @jieyouxu.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: compiler
  • compiler expanded to 76 candidates
  • Random selection from 21 candidates

jieyouxu
jieyouxu approved these changes Sep 11, 2026
View reviewed changes

@jieyouxu jieyouxu left a comment •
edited by rustbot
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, r=me once PR CI is green.

View changes since this review

@chenyukang

chenyukang commented Sep 11, 2026

Copy link
Copy Markdown
Member Author

@bors r=jieyouxu

@rust-bors

rust-bors Bot commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

📌 Commit 6581f4c has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 11, 2026
@jhpratt jhpratt mentioned this pull request Sep 11, 2026
Merged
rust-bors Bot pushed a commit that referenced this pull request Sep 11, 2026
@bors
Auto merge of #162622 - jhpratt:rollup-F7fv0Yu, r=jhpratt
a59b87a 
Rollup of 10 pull requests

Successful merges:

 - #162270 (Update `windows-bindgen` to 0.100.0)
 - #162492 (Revert "Rollup merge of #157518 - CAD97:xdg_basedir, r=aapoalas")
 - #162607 (Basic cleanup in `rustc_transmute`)
 - #162619 (Add test for the missing Clone requirement for Cow slices)
 - #162172 (mention the opaque when its hidden type cannot be inferred)
 - #162514 (Simplify diagnostic levels)
 - #162546 (Use lld by default on `loongarch64-unknown-linux-gnu` nightly)
 - #162564 (yeet StabilityLevel)
 - #162613 (iter::repeat_with, iter::successors, iter::from_fn added as diagnostic items)
 - #162616 (regression test for async main diagnostic)
@rust-bors
rust-bors Bot merged commit 0180298 into rust-lang:main Sep 11, 2026
13 checks passed
@rustbot rustbot added this to the 1.100.0 milestone Sep 11, 2026
rust-bors Bot pushed a commit that referenced this pull request Sep 11, 2026
@bors
Unrolled build for #162619 in rollup 162622
8dd8ba9 
Rollup merge of #162619 - chenyukang:yukang-fix-141241-cow-clone-diagnostic-test, r=jieyouxu

Add test for the missing Clone requirement for Cow slices

Fixes #141241
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jieyouxu jieyouxu jieyouxu approved these changes

Assignees

@jieyouxu jieyouxu

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.

Projects

None yet

Milestone

1.100.0

Development

Successfully merging this pull request may close these issues.

Suboptimal diagnostic for Cow<'static, [SomeType]> if SomeType doesn't implement Clone

3 participants

@chenyukang @rustbot @jieyouxu