Basic cleanup in rustc_transmute - #162607
Merged
Merged
Conversation
Explain the byte alphabet, padding, definition markers, and empty layouts. Cover surviving and fully pruned alternatives, including nested sequences, and replace obsolete visibility terminology. Validation: ./x test compiler/rustc_transmute Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
Describe the query stages and deferred obligations, correct stale comments, and exercise both validity settings in the powerset test. Add direct checks for condition grouping, error selection, and quantifier short-circuiting. Document the existing conditional behavior of Answer::or without changing it. Validation: ./x test compiler/rustc_transmute Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
Specify interval-union inputs and output partitions and test overlaps, boundaries, and coalescing. Mark DOT entry and accepting states distinctly, log full graphs once per query, and omit the memoization cache from spans. Validation: ./x test compiler/rustc_transmute A manual bool identity query with RUSTC_LOG=rustc_transmute=debug confirmed one source graph, one destination graph, and no cache dumps. Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
Use each YawningVoid type as a destination in its UI test instead of repeating the zero-sized Void case. Equal-sized u128 sources prevent a size mismatch from masking a failure to reject an uninhabited destination. Update the copied explanations and regenerate the diagnostic snapshot. Validation: ./x test tests/ui/transmutability Agent-Authored-By: AI agent acting on Josh Liebow-Feeser's behalf
rustbot
added
S-waiting-on-review
joshlf
force-pushed
the
transmute-cleanup
branch
from
September 10, 2026 20:15
dc625a4 to
ac29954
Compare
Member
|
@bors r+ |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Sep 10, 2026
Basic cleanup in `rustc_transmute` The content of this PR was authored by an LLM. r? @jswrenn
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup of 5 pull requests Successful merges: - #162270 (Update `windows-bindgen` to 0.100.0) - #162492 (Revert "Rollup merge of #157518 - CAD97:xdg_basedir, r=aapoalas") - #162607 (Basic cleanup in `rustc_transmute`) - #162514 (Simplify diagnostic levels) - #162613 (iter::repeat_with, iter::successors, iter::from_fn added as diagnostic items)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup of 10 pull requests Successful merges: - #162270 (Update `windows-bindgen` to 0.100.0) - #162492 (Revert "Rollup merge of #157518 - CAD97:xdg_basedir, r=aapoalas") - #162607 (Basic cleanup in `rustc_transmute`) - #162619 (Add test for the missing Clone requirement for Cow slices) - #162172 (mention the opaque when its hidden type cannot be inferred) - #162514 (Simplify diagnostic levels) - #162546 (Use lld by default on `loongarch64-unknown-linux-gnu` nightly) - #162564 (yeet StabilityLevel) - #162613 (iter::repeat_with, iter::successors, iter::from_fn added as diagnostic items) - #162616 (regression test for async main diagnostic)
hanna-kruppe
added
the
llm-assisted
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The content of this PR was authored by an LLM.
r? @jswrenn