split macroless_generic_const_args in two - #162541
Merged
Merged
Conversation
rustbot
added
S-waiting-on-review
10 tasks
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
twos_a_crowd
branch
from
September 9, 2026 15:18
942378f to
93c9b4e
Compare
fbstj
reviewed
Sep 9, 2026
BoxyUwU
force-pushed
the
twos_a_crowd
branch
from
September 9, 2026 15:24
93c9b4e to
6bc3284
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
twos_a_crowd
branch
from
September 9, 2026 15:34
6bc3284 to
135aa2f
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
removed
the
S-waiting-on-review
rustbot
added
the
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
twos_a_crowd
branch
from
September 10, 2026 10:00
135aa2f to
6950a81
Compare
This comment has been minimized.
This comment has been minimized.
BoxyUwU
force-pushed
the
twos_a_crowd
branch
from
September 10, 2026 15:23
6950a81 to
d5ef83f
Compare
This comment has been minimized.
This comment has been minimized.
Member
Author
|
OH MY |
BoxyUwU
force-pushed
the
twos_a_crowd
branch
from
September 10, 2026 18:47
d5ef83f to
15d0810
Compare
Member
|
gg ci, no re pls @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 11, 2026
split `macroless_generic_const_args` in two Two's a crowd! But One's a lonely. Having `macroless_generic_const_args` apply to const items was quite annoying for users especially as we moved away from `type const` to just regular const items. We would quite commonly be "guessing wrong" with no easy way for users to opt out of `const ASSOC: usize = ...` being represented directly instead of an opaque body I just swapped any failing tests over to using macroless_const_item_generic_const_args, didnt look through the whole set :> We should probably bikeshed the feature name rn because it's currently inconsistent with what we wanted to rename all of the other gca features too :> Maybe this should be `gca_macroless_const_items` cc rust-lang#162540 r? khyperia
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 11, 2026
split `macroless_generic_const_args` in two Two's a crowd! But One's a lonely. Having `macroless_generic_const_args` apply to const items was quite annoying for users especially as we moved away from `type const` to just regular const items. We would quite commonly be "guessing wrong" with no easy way for users to opt out of `const ASSOC: usize = ...` being represented directly instead of an opaque body I just swapped any failing tests over to using macroless_const_item_generic_const_args, didnt look through the whole set :> We should probably bikeshed the feature name rn because it's currently inconsistent with what we wanted to rename all of the other gca features too :> Maybe this should be `gca_macroless_const_items` cc rust-lang#162540 r? khyperia
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
…uwer Rollup of 10 pull requests Successful merges: - #162126 (Rename various resolving functions for consistency, and document them) - #162520 (Refactor `HygieneEncodeContext`) - #154373 (Skip linting unused braces for FunctionArg and MethodArg context for 2024 later ) - #160023 (Refactor the way cg_ssa handles indirect returns (returns via `sret`) — Take 2) - #161482 (Use attribute parser for `#[non_exhaustive]` attribute check) - #161867 (deeper `rustc_builtin_macros` cleanups) - #162099 (small refactor of doc attribute arguments warnings) - #162541 (split `macroless_generic_const_args` in two) - #162549 (The fuchsia team maintains `riscv64gc-unknown-fuchsia`) - #162577 (Fix `i686-pc-windows-msvc` platform support docs and target spec metadata)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 11, 2026
split `macroless_generic_const_args` in two Two's a crowd! But One's a lonely. Having `macroless_generic_const_args` apply to const items was quite annoying for users especially as we moved away from `type const` to just regular const items. We would quite commonly be "guessing wrong" with no easy way for users to opt out of `const ASSOC: usize = ...` being represented directly instead of an opaque body I just swapped any failing tests over to using macroless_const_item_generic_const_args, didnt look through the whole set :> We should probably bikeshed the feature name rn because it's currently inconsistent with what we wanted to rename all of the other gca features too :> Maybe this should be `gca_macroless_const_items` cc rust-lang#162540 r? khyperia
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
…uwer Rollup of 11 pull requests Successful merges: - #162520 (Refactor `HygieneEncodeContext`) - #154373 (Skip linting unused braces for FunctionArg and MethodArg context for 2024 later ) - #160023 (Refactor the way cg_ssa handles indirect returns (returns via `sret`) — Take 2) - #160860 (Implement arbitrary casts in custom mir) - #161482 (Use attribute parser for `#[non_exhaustive]` attribute check) - #161867 (deeper `rustc_builtin_macros` cleanups) - #162099 (small refactor of doc attribute arguments warnings) - #162541 (split `macroless_generic_const_args` in two) - #162549 (The fuchsia team maintains `riscv64gc-unknown-fuchsia`) - #162577 (Fix `i686-pc-windows-msvc` platform support docs and target spec metadata) - #162624 (regression test for opaque field projection in closure capture)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup merge of #162541 - BoxyUwU:twos_a_crowd, r=khyperia split `macroless_generic_const_args` in two Two's a crowd! But One's a lonely. Having `macroless_generic_const_args` apply to const items was quite annoying for users especially as we moved away from `type const` to just regular const items. We would quite commonly be "guessing wrong" with no easy way for users to opt out of `const ASSOC: usize = ...` being represented directly instead of an opaque body I just swapped any failing tests over to using macroless_const_item_generic_const_args, didnt look through the whole set :> We should probably bikeshed the feature name rn because it's currently inconsistent with what we wanted to rename all of the other gca features too :> Maybe this should be `gca_macroless_const_items` cc #162540 r? khyperia
Collaborator
|
Note This PR was benchmarked as part of triage of its containing rollup: triage URL. Finished benchmarking commit (aa10195): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)Results (primary 0.6%, secondary -4.6%)A less reliable metric. May be of interest, but not used to determine the overall result above.
CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: missing data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two's a crowd! But One's a lonely.
Having
macroless_generic_const_argsapply to const items was quite annoying for users especially as we moved away fromtype constto just regular const items. We would quite commonly be "guessing wrong" with no easy way for users to opt out ofconst ASSOC: usize = ...being represented directly instead of an opaque bodyI just swapped any failing tests over to using macroless_const_item_generic_const_args, didnt look through the whole set :>
We should probably bikeshed the feature name rn because it's currently inconsistent with what we wanted to rename all of the other gca features too :> Maybe this should be
gca_macroless_const_itemscc #162540
r? khyperia