small refactor of doc attribute arguments warnings - #162099
Merged
Merged
Conversation
Collaborator
|
Some changes occurred in compiler/rustc_attr_parsing |
rustbot
added
A-attributes
rustbot
added
the
T-rustdoc
Collaborator
|
r? @mati865 rustbot has assigned @mati865. Use Why was this reviewer chosen?The reviewer was selected based on:
|
| ); | ||
| } | ||
| ArgParser::List(items) => { | ||
| ArgParser::List(items) if !items.is_empty() => { |
Member
There was a problem hiding this comment.
Hmmm I'm not sure how I feel about a INVALID_DOC_ATTRIBUTES on #[doc()], could you motivate this change?
I think UNUSED_ATTRIBUTES might be nicer.
Other attributes, such as #[repr()], #![feature()] also do this.
Member
Author
There was a problem hiding this comment.
#[doc], #[doc(bogus)] etc emit invalid_doc_attributes. I think #[doc()] fits right in.
Member
There was a problem hiding this comment.
I guess I just don't like that INVALID_DOC_ATTRIBUTES exists at all, but it does so indeed it does fit in
JonathanBrouwer
requested changes
Sep 1, 2026
rustbot
added
S-waiting-on-author
mejrs
added
S-waiting-on-review
JonathanBrouwer
approved these changes
Sep 11, 2026
Contributor
rust-bors
Bot
added
S-waiting-on-bors
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 11, 2026
small refactor of doc attribute arguments warnings
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
…uwer Rollup of 10 pull requests Successful merges: - #162126 (Rename various resolving functions for consistency, and document them) - #162520 (Refactor `HygieneEncodeContext`) - #154373 (Skip linting unused braces for FunctionArg and MethodArg context for 2024 later ) - #160023 (Refactor the way cg_ssa handles indirect returns (returns via `sret`) — Take 2) - #161482 (Use attribute parser for `#[non_exhaustive]` attribute check) - #161867 (deeper `rustc_builtin_macros` cleanups) - #162099 (small refactor of doc attribute arguments warnings) - #162541 (split `macroless_generic_const_args` in two) - #162549 (The fuchsia team maintains `riscv64gc-unknown-fuchsia`) - #162577 (Fix `i686-pc-windows-msvc` platform support docs and target spec metadata)
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 11, 2026
small refactor of doc attribute arguments warnings
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
…uwer Rollup of 11 pull requests Successful merges: - #162520 (Refactor `HygieneEncodeContext`) - #154373 (Skip linting unused braces for FunctionArg and MethodArg context for 2024 later ) - #160023 (Refactor the way cg_ssa handles indirect returns (returns via `sret`) — Take 2) - #160860 (Implement arbitrary casts in custom mir) - #161482 (Use attribute parser for `#[non_exhaustive]` attribute check) - #161867 (deeper `rustc_builtin_macros` cleanups) - #162099 (small refactor of doc attribute arguments warnings) - #162541 (split `macroless_generic_const_args` in two) - #162549 (The fuchsia team maintains `riscv64gc-unknown-fuchsia`) - #162577 (Fix `i686-pc-windows-msvc` platform support docs and target spec metadata) - #162624 (regression test for opaque field projection in closure capture)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 11, 2026
Rollup merge of #162099 - mejrs:doc_values, r=JonathanBrouwer small refactor of doc attribute arguments warnings
Collaborator
|
Note This PR was benchmarked as part of triage of its containing rollup: triage URL. Finished benchmarking commit (0e0356e): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis perf run didn't have relevant results for this metric. Max RSS (memory usage)This perf run didn't have relevant results for this metric. CyclesThis perf run didn't have relevant results for this metric. Binary sizeThis perf run didn't have relevant results for this metric. Bootstrap: missing data |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.