Fix run-make/prune-link-args to work with MinGW - #162534
Merged
Merged
Conversation
The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.
rustbot
added
A-run-make
Collaborator
|
r? @oli-obk rustbot has assigned @oli-obk. Use Why was this reviewer chosen?The reviewer was selected based on:
|
Member
Author
|
@bors try jobs=testmingw,testtest-x86_64-msvc- |
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Fix run-make/prune-link-args to work with MinGW try-job: test*mingw* try-job: test*test-x86_64-msvc-*
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors try cancel |
Contributor
|
Try build cancelled. Cancelled workflows: Hint: if you want to run another try build, you do not need to manually cancel the previous one. Just run |
Member
Author
|
@bors try jobs=testmingw,test-x86_64-msvc-* |
This comment has been minimized.
This comment has been minimized.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Fix run-make/prune-link-args to work with MinGW try-job: test*mingw* try-job: test-x86_64-msvc-*
Member
I'm pretty sure |
Contributor
Contributor
|
@bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Member
Author
|
I'm not sure if this is safe to rollup, but should be easy to track down if it causes a failure. |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Sep 10, 2026
… r=oli-obk Fix run-make/prune-link-args to work with MinGW The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162581 (Subtree sync for rustc_codegen_cranelift) - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds) - #162057 (Some cleanups around fatal errors and delayed bugs) - #162437 (fix(traits): Remove expression references from index suggestions) - #162534 (Fix run-make/prune-link-args to work with MinGW) - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
…uwer Rollup of 6 pull requests Successful merges: - #162581 (Subtree sync for rustc_codegen_cranelift) - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds) - #162057 (Some cleanups around fatal errors and delayed bugs) - #162437 (fix(traits): Remove expression references from index suggestions) - #162534 (Fix run-make/prune-link-args to work with MinGW) - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
…uwer Rollup of 7 pull requests Successful merges: - #162581 (Subtree sync for rustc_codegen_cranelift) - #160831 (re-equate the object bound's trait ref with the goal's when considering object bounds) - #162057 (Some cleanups around fatal errors and delayed bugs) - #162437 (fix(traits): Remove expression references from index suggestions) - #162534 (Fix run-make/prune-link-args to work with MinGW) - #162554 (Attemped fix for home dir problem on `dist-aarch64-llvm-mingw`) - #162576 (doc: Fix external mention of signum() return value regarding NaNs)
rust-bors Bot
pushed a commit
that referenced
this pull request
Sep 10, 2026
Rollup merge of #162534 - mati865:prun-link-args-test-mingw, r=oli-obk Fix run-make/prune-link-args to work with MinGW The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The explanation provided was wrong. Libc doesn't exist on Windows, so naturally this failed on missing lib. I have no idea what shenanigans link.exe does to make this pass, but surely it doesn't actually link libc.